linux-kernel - Re: [PATCH net-next v5 2/6] dt-bindings: net: Brcm ASP 2.0 Ethernet controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f0e3a10f-be6f-8e52-082f-70d2b8f42715@broadcom.com>
Date:   Wed, 31 May 2023 12:38:24 -0700
From:   Florian Fainelli <florian.fainelli@...adcom.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Justin Chen <justin.chen@...adcom.com>, netdev@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        dri-devel@...ts.freedesktop.org,
        bcm-kernel-feedback-list@...adcom.com
Cc:     davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
        pabeni@...hat.com, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
        opendmb@...il.com, andrew@...n.ch, hkallweit1@...il.com,
        linux@...linux.org.uk, richardcochran@...il.com,
        sumit.semwal@...aro.org, christian.koenig@....com,
        simon.horman@...igine.com
Subject: Re: [PATCH net-next v5 2/6] dt-bindings: net: Brcm ASP 2.0 Ethernet
 controller

On 5/31/23 12:31, Krzysztof Kozlowski wrote:
> On 31/05/2023 21:29, Florian Fainelli wrote:
>>>> +        required:
>>>> +          - reg
>>>> +          - brcm,channel
>>>> +
>>>> +    additionalProperties: false
>>>> +
>>>> +patternProperties:
>>>> +  "^mdio@[0-9a-f]+$":
>>>
>>> Isn't mdio a property of each ethernet port? Existing users
>>> (e.g.bcmgenet, owl-emac, switches) do it that way...
>>
>> They are sub-nodes of the larger Ethernet controller block, hence the
>> property here.
> 
> This is the Ethernet controller. They are subnodes here, so what do you
> mean by that? They are part of some other block?

The block is not just an Ethernet controller it has other functions, 
which is why we went with a top-level node with a 'ranges' property. One 
of those functions are the MDIO bus controllers. The examples makes it 
reasonably clear.

> 
>>
>>>
>>> Otherwise how do you define relation-ship? Can one mdio fit multiple ports?
>>
>> The relationship is established between Ethernet ports and children
>> nodes of the MDIO controller, such as switches or Ethernet PHYs using
>> 'phy-handle' for instance. And yes, a single/common MDIO controller
>> could be serving multiple Ethernet ports.
> 
> We do not talk about generic case, but your device.

The generic case is true here as well. We so happen to have a 1:1 
mapping between the MDIO controller, PHY, and Ethernet port, in this 
particular example.
-- 
Florian


Download attachment "smime.p7s" of type "application/pkcs7-signature" (4221 bytes)