linux-kernel - Re: [PATCH net-next v5 3/6] net: bcmasp: Add support for ASP2.0 Ethernet controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bda74174-6623-e657-eb7a-bda278882fff@broadcom.com>
Date:   Wed, 31 May 2023 14:32:59 -0700
From:   Florian Fainelli <florian.fainelli@...adcom.com>
To:     Justin Chen <justin.chen@...adcom.com>, netdev@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        dri-devel@...ts.freedesktop.org,
        bcm-kernel-feedback-list@...adcom.com
Cc:     davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
        pabeni@...hat.com, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
        opendmb@...il.com, andrew@...n.ch, hkallweit1@...il.com,
        linux@...linux.org.uk, richardcochran@...il.com,
        sumit.semwal@...aro.org, christian.koenig@....com,
        simon.horman@...igine.com
Subject: Re: [PATCH net-next v5 3/6] net: bcmasp: Add support for ASP2.0
 Ethernet controller

On 5/24/23 16:01, Justin Chen wrote:
> Add support for the Broadcom ASP 2.0 Ethernet controller which is first
> introduced with 72165. This controller features two distinct Ethernet
> ports that can be independently operated.
> 
> This patch supports:
> 
> - Wake-on-LAN using magic packets
> - basic ethtool operations (link, counters, message level)
> - MAC destination address filtering (promiscuous, ALL_MULTI, etc.)
> 
> Reviewed-by: Simon Horman <simon.horman@...igine.com>
> Signed-off-by: Florian Fainelli <florian.fainelli@...adcom.com>
> Signed-off-by: Justin Chen <justin.chen@...adcom.com>
> ---

[snip]

> +static const struct net_device_ops bcmasp_netdev_ops = {
> +	.ndo_open		= bcmasp_open,
> +	.ndo_stop		= bcmasp_stop,
> +	.ndo_start_xmit		= bcmasp_xmit,
> +	.ndo_tx_timeout		= bcmasp_tx_timeout,
> +	.ndo_set_rx_mode	= bcmasp_set_rx_mode,
> +	.ndo_get_phys_port_name	= bcmasp_get_phys_port_name,
> +	.ndo_get_stats		= bcmasp_get_stats,
> +	.ndo_do_ioctl		= bcmasp_ioctl,

This needs to be:

@@ -1207,7 +1196,7 @@ static const struct net_device_ops 
bcmasp_netdev_ops = {
         .ndo_set_rx_mode        = bcmasp_set_rx_mode,
         .ndo_get_phys_port_name = bcmasp_get_phys_port_name,
         .ndo_get_stats          = bcmasp_get_stats,
-       .ndo_do_ioctl           = bcmasp_ioctl,
+       .ndo_eth_ioctl          = phy_do_ioctl_running,
         .ndo_set_mac_address    = bcmasp_set_mac_address,
  };

such that MII ioctls work properly.
-- 
Florian


Download attachment "smime.p7s" of type "application/pkcs7-signature" (4221 bytes)