[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZHjtExYIdVFo3HnB@makrotopia.org>
Date: Thu, 1 Jun 2023 20:10:11 +0100
From: Daniel Golle <daniel@...rotopia.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc: devicetree@...r.kernel.org, linux-i2c@...r.kernel.org,
linux-mediatek@...ts.infradead.org,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
Conor Dooley <conor+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Rob Herring <robh+dt@...nel.org>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@...labora.com>,
Matthias Brugger <matthias.bgg@...il.com>,
Qii Wang <qii.wang@...iatek.com>,
Sam Shih <sam.shih@...iatek.com>,
郭小桥 <joe@...nstrong.cn>
Subject: Re: [PATCH 1/2] dt-bindings: i2c: i2c-mt65xx: add additional clocks
On Thu, Jun 01, 2023 at 06:54:01PM +0200, Krzysztof Kozlowski wrote:
> On 31/05/2023 18:10, Daniel Golle wrote:
> > Add pck and mck clocks which are needed to access I2C registers on MT7981.
> >
> > Signed-off-by: Daniel Golle <daniel@...rotopia.org>
> > ---
> > Documentation/devicetree/bindings/i2c/i2c-mt65xx.yaml | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/i2c/i2c-mt65xx.yaml b/Documentation/devicetree/bindings/i2c/i2c-mt65xx.yaml
> > index fda0467cdd954..550795f6573c5 100644
> > --- a/Documentation/devicetree/bindings/i2c/i2c-mt65xx.yaml
> > +++ b/Documentation/devicetree/bindings/i2c/i2c-mt65xx.yaml
> > @@ -78,6 +78,8 @@ properties:
> > - const: dma
> > - const: arb
> > - const: pmic
> > + - const: mck
> > + - const: pck
> >
>
> Adding names does not magically add the clocks. This wasn't tested.
Adding the clocks is done in patch 2/2 which just wasn't sent to
devicetree@ and dt maintainers, but to the relevant mailing lists
instead. Was that wrong and should I always send the complete series
also to devicetree@ as well as dt maintainers?
Anyway. It turns out that arb and pmic clocks are intended for that,
so we can cancel this and I'll just use those instead.
Powered by blists - more mailing lists