linux-kernel - Re: [PATCH v4 13/23] cxl/hdm: Use stored Component Register mappings to map HDM decoder capability

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230601141115.00006b6a@Huawei.com>
Date:   Thu, 1 Jun 2023 14:11:15 +0100
From:   Jonathan Cameron <Jonathan.Cameron@...wei.com>
To:     Terry Bowman <terry.bowman@....com>
CC:     <alison.schofield@...el.com>, <vishal.l.verma@...el.com>,
        <ira.weiny@...el.com>, <bwidawsk@...nel.org>,
        <dan.j.williams@...el.com>, <dave.jiang@...el.com>,
        <linux-cxl@...r.kernel.org>, <rrichter@....com>,
        <linux-kernel@...r.kernel.org>, <bhelgaas@...gle.com>
Subject: Re: [PATCH v4 13/23] cxl/hdm: Use stored Component Register
 mappings to map HDM decoder capability

On Tue, 23 May 2023 18:22:04 -0500
Terry Bowman <terry.bowman@....com> wrote:

> From: Robert Richter <rrichter@....com>
> 
> Now, that the Component Register mappings are stored, use them to
> enable and map the HDM decoder capabilities. The Component Registers
> do not need to be probed again for this, remove probing code.
> 
> The HDM capability applies to Endpoints, USPs and VH Host Bridges. The
> Endpoint's component register mappings are located in the cxlds and
> else in the port's structure. Provide a helper function
> cxl_port_get_comp_map() to locate the mappings depending on the
> component's type.
> 
> Signed-off-by: Robert Richter <rrichter@....com>
> Signed-off-by: Terry Bowman <terry.bowman@....com>
Other than the static you already fixed this looks good to me.
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>