linux-kernel - Re: [PATCH V7 4/8] pinctrl: qcom: Add IPQ5018 pinctrl driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fb95bebd-52ec-eda5-22c3-c3e494e29674@quicinc.com>
Date:   Fri, 2 Jun 2023 08:51:07 +0530
From:   Sricharan Ramabadhran <quic_srichara@...cinc.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        <andy.shevchenko@...il.com>
CC:     <agross@...nel.org>, <andersson@...nel.org>,
        <konrad.dybcio@...aro.org>, <robh+dt@...nel.org>,
        <krzysztof.kozlowski+dt@...aro.org>, <mturquette@...libre.com>,
        <sboyd@...nel.org>, <ulf.hansson@...aro.org>,
        <linus.walleij@...aro.org>, <catalin.marinas@....com>,
        <will@...nel.org>, <p.zabel@...gutronix.de>,
        <linux-arm-msm@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <linux-mmc@...r.kernel.org>,
        <linux-gpio@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>, <robimarko@...il.com>
Subject: Re: [PATCH V7 4/8] pinctrl: qcom: Add IPQ5018 pinctrl driver



On 6/1/2023 6:57 PM, Krzysztof Kozlowski wrote:
> On 01/06/2023 13:53, Krzysztof Kozlowski wrote:
>> On 01/06/2023 13:41, Sricharan Ramabadhran wrote:
>>>
>>>
>>> On 6/1/2023 3:21 PM, Krzysztof Kozlowski wrote:
>>>> On 01/06/2023 11:50, Sricharan Ramabadhran wrote:
>>>>>
>>>>>
>>>>> On 5/29/2023 9:25 PM, andy.shevchenko@...il.com wrote:
>>>>>> Mon, May 29, 2023 at 03:58:09PM +0530, Sricharan Ramabadhran kirjoitti:
>>>>>>> On 5/20/2023 12:17 AM, Andy Shevchenko wrote:
>>>>>>>> On Fri, May 19, 2023 at 3:55 PM Sricharan Ramabadhran
>>>>>>>> <quic_srichara@...cinc.com> wrote:
>>>>>>
>>>>>> ...
>>>>>>
>>>>>>>>       depends on OF || COMPILE_TEST
>>>>>>>
>>>>>>>     Yeah sure. COMPILE_TEST could be standalone. Will fix it and repost.
>>>>>>
>>>>>> Standalone COMPILE_TEST will give you definitely NOT what you want.
>>>>>> And actually it's strange to have it standalone.
>>>>>>
>>>>>
>>>>>     Ho ok, i meant like this, "depends on ARM64 || COMPILE_TEST"
>>>>
>>>> Don't do it differently than all other drivers. Open the Kconfig and
>>>> look at existing entries.
>>>>
>>>     The latest added has this below, will use this
>>>
>>> 	depends on OF || COMPILE_TEST
>>
>> I would even drop this... Lemme check, it looks odd. We depend on
>> ARCH_QCOM which uses OF. We have few drivers which depend on ACPI, but
>> that also seems wrong. These are platform drivers so they should expect
>> platform select proper firmware interface. I think none of other
>> platform drivers do like this (neither Samsung pinctrl nor other
>> Qualcomm drivers)).
>>
>> I will fix this. For your patch I would just skip OF entirely.
> 
> Correction: you need OF :(

  yup, will follow the same then.

Regards,
  Sricharan