linux-kernel - Re: [Intel-gfx] [PATCH] drm/i915/pxp: use correct format string for size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 2 Jun 2023 02:43:56 +0200
From:   Andi Shyti <andi.shyti@...ux.intel.com>
To:     "Teres Alexis, Alan Previn" <alan.previn.teres.alexis@...el.com>
Cc:     "joonas.lahtinen@...ux.intel.com" <joonas.lahtinen@...ux.intel.com>,
        "Vivi, Rodrigo" <rodrigo.vivi@...el.com>,
        "arnd@...nel.org" <arnd@...nel.org>,
        "tvrtko.ursulin@...ux.intel.com" <tvrtko.ursulin@...ux.intel.com>,
        "jani.nikula@...ux.intel.com" <jani.nikula@...ux.intel.com>,
        "arnd@...db.de" <arnd@...db.de>,
        "intel-gfx@...ts.freedesktop.org" <intel-gfx@...ts.freedesktop.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "daniel@...ll.ch" <daniel@...ll.ch>,
        "airlied@...il.com" <airlied@...il.com>
Subject: Re: [Intel-gfx] [PATCH] drm/i915/pxp: use correct format string for
 size_t

Hi Arnd,

On Thu, Jun 01, 2023 at 10:00:27PM +0000, Teres Alexis, Alan Previn wrote:
> On Thu, 2023-06-01 at 23:36 +0200, Arnd Bergmann wrote:
> > From: Arnd Bergmann <arnd@...db.de>
> > 
> > While 'unsigned long' needs the %ld format string, size_t needs the %z
> > modifier:
> 
> alan:snip
> 
> 
> > +++ b/drivers/gpu/drm/i915/pxp/intel_pxp_gsccs.c
> > @@ -143,7 +143,7 @@ gsccs_send_message(struct intel_pxp *pxp,
> >  
> >  	reply_size = header->message_size - sizeof(*header);
> >  	if (reply_size > msg_out_size_max) {
> > -		drm_warn(&i915->drm, "caller with insufficient PXP reply size %u (%ld)\n",
> > +		drm_warn(&i915->drm, "caller with insufficient PXP reply size %u (%zd)\n",
> >  			 reply_size, msg_out_size_max);
> >  		reply_size = msg_out_size_max;
> >  	}
> Thanks Arnd for catching this, although i believe Nathan sumbmitted a patch for the same fix yesterday and received an RB from Andi.

yes, the patch is here:

https://patchwork.freedesktop.org/patch/540272/?series=118593&rev=1

I'm waiting for full CI results to merge this.

Thanks,
Andi