linux-kernel - Re: [PATCH v5 4/7] iio: light: vcnl4000: add illuminance irq vcnl4040/4200

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230604121607.1f633e61@jic23-huawei>
Date:   Sun, 4 Jun 2023 12:16:07 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     andy.shevchenko@...il.com
Cc:     Astrid Rost <astrid.rost@...s.com>,
        Lars-Peter Clausen <lars@...afoo.de>,
        linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel@...s.com,
        Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>,
        Mathieu Othacehe <m.othacehe@...il.com>
Subject: Re: [PATCH v5 4/7] iio: light: vcnl4000: add illuminance irq
 vcnl4040/4200


> ...
> 
> > -	val = state ? (ret | mask) : (ret & ~mask);
> > +		val = state ? (ret | mask) : (ret & ~mask);  
> 
> I'm wondering if you can prepere the code by introducing switch-case instead of
> current implementation in the preparatory patch and then do what you want to do
> here. It will show much better the change and make review easier.
> 
Agreed. Diff wasn't being particularly helpful in how it handled the changes here
so helping it along with a precursor patch would be good.

Jonathan