linux-kernel - Re: [PATCH v5 0/7] iio: light: vcnl4000: Add features for vncl4040/4200

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 4 Jun 2023 12:20:15 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     andy.shevchenko@...il.com
Cc:     Astrid Rost <astrid.rost@...s.com>,
        Lars-Peter Clausen <lars@...afoo.de>,
        linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel@...s.com,
        Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>,
        Mathieu Othacehe <m.othacehe@...il.com>
Subject: Re: [PATCH v5 0/7] iio: light: vcnl4000: Add features for
 vncl4040/4200

On Sat, 3 Jun 2023 16:54:10 +0300
andy.shevchenko@...il.com wrote:

> Tue, May 30, 2023 at 04:23:58PM +0200, Astrid Rost kirjoitti:
> > Add a more complete support for vncl4040 and vcnl4200, which allows to
> > change the distance of proximity detection and interrupt support for the
> > illuminance sensor.
> > 
> > Proximity functionality:
> >   - Interrupt support (new on vcnl4200).
> > 
> > Proximity reduce the amount of interrupts:
> >   - Adaptable integration time (new on vcnl4200) - the sampling rate
> >     changes according to this value.
> >   - Period - interrupt is asserted if the value is above or
> >     below a certain threshold.
> > 
> > Proximity change the activity distance:
> >   - Oversampling ratio - Amount of LED pulses per measured raw value.
> >   - Calibration bias - LED current calibration of the sensor.
> > 
> > Illuminance functionality:
> >   - Interrupt support.
> > 
> > Illuminance reduce the amount of interrupts:
> >   - Adaptable integration time - the sampling rate and scale changes
> >     according to this value.
> >   - Period – interrupt is asserted if the value is above or
> >     below a certain threshold.  
> 
> It's a good work, thank you for doing it!
> 
> But it has a lot of small style and inconsistent issues. They are not major
> per se, but since there is more than 3, it makes sense to address. Also check
> if you can split your patches to two or three where it makes sense.
> 

FWIW nothing to add from me.  Agree with Andy that we are down to style
things that would be good to tidy up before applying these.

Adding levels to switch nests always makes for ugly diffs so I fully agree
with Andy that, though trivial, it is probably better to do those in two steps
for ease of review.  If there is just one in a patch then meh, we can probably
cope with the extra thinking required to review them , but where it happens
several times it's worth making reviewer's lives that little bit easier!

Jonathan