linux-kernel - RE: [PATCH v2 3/5] dt-bindings: hwmon: hpe,gxp-fanctrl: remove fn2 and pl regs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 5 Jun 2023 16:52:48 +0000
From:   "Hawkins, Nick" <nick.hawkins@....com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        "krzysztof.kozlowski+dt@...aro.org" 
        <krzysztof.kozlowski+dt@...aro.org>
CC:     "jdelvare@...e.com" <jdelvare@...e.com>,
        "linux@...ck-us.net" <linux@...ck-us.net>,
        "andy.shevchenko@...il.com" <andy.shevchenko@...il.com>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-hwmon@...r.kernel.org" <linux-hwmon@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "Verdun, Jean-Marie" <verdun@....com>,
        "linus.walleij@...aro.org" <linus.walleij@...aro.org>,
        "brgl@...ev.pl" <brgl@...ev.pl>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>
Subject: RE: [PATCH v2 3/5] dt-bindings: hwmon: hpe,gxp-fanctrl: remove fn2
 and pl regs

> > Remove the fn2 register and pl register references as these memory areas
> > are now consumed by the GXP GPIO driver. The fan driver now gathers fan
> > information from GPIO driver.

> How is it expressed in bindings? I don't see it.

Greetings Krzysztof,

Thanks for the feedback. Just to confirm: Is this comment referring to the
content of the patch description? For the third version I want to make sure
I address your concern.

In the third version I will be modifying the description once more as I will
no longer retrieve data from the GPIO driver. Here is the new attempt:

dt-bindings: hwmon: hpe,gxp-fan-ctrl: remove fn2 and pl register references

Reduce the hpe,gxp-fan-ctrl register references from 3 to 1. The function2
(fn2) and programmable logic (pl) references are removed. The purpose
of removal being their functionality will be consumed by a new GPIO
driver.

Thank you for the assistance,

-Nick Hawkins