linux-kernel - Re: [PATCH v8 02/33] x86/fred: make unions for the cs and ss fields in struct pt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 05 Jun 2023 19:29:54 +0200
From:   Thomas Gleixner <tglx@...utronix.de>
To:     "H. Peter Anvin" <hpa@...or.com>, Xin Li <xin3.li@...el.com>,
        linux-kernel@...r.kernel.org, x86@...nel.org, kvm@...r.kernel.org
Cc:     mingo@...hat.com, bp@...en8.de, dave.hansen@...ux.intel.com,
        peterz@...radead.org, andrew.cooper3@...rix.com, seanjc@...gle.com,
        pbonzini@...hat.com, ravi.v.shankar@...el.com,
        jiangshanlai@...il.com, shan.kang@...el.com
Subject: Re: [PATCH v8 02/33] x86/fred: make unions for the cs and ss fields
 in struct pt_regs

On Mon, Jun 05 2023 at 10:12, H. Peter Anvin wrote:
>> 
>> This does not match section
>> 
>>      5.2.1 Saving Information on the Regular Stack?
>> 
>> of version 4 and later of the specification.
>> 
>
> Yes, this is correct. This patchset was posted in April, and once we got 
> some very late requests for changes I asked Xin to hold off any further 
> iterations until the spec had restabilized.

I assumed that, but I stumbled over it when trying to review :)