linux-kernel - Re: [PATCH 1/2] regulator: act8945a: rely on hardware for operating mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 5 Jun 2023 20:01:03 +0530
From:   Raag Jadav <raagjadav@...il.com>
To:     Mark Brown <broonie@...nel.org>
Cc:     Liam Girdwood <lgirdwood@...il.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] regulator: act8945a: rely on hardware for operating
 mode

On Mon, Jun 05, 2023 at 01:16:33PM +0100, Mark Brown wrote:
> On Mon, Jun 05, 2023 at 04:18:29PM +0530, Raag Jadav wrote:
> 
> > Convert ->get_mode() and ->set_mode() hooks to read/write operating mode
> > from/to hardware instead of relying on driver memory.
> 
> Why is this change being made - what is the benefit here?

Original implementation uses drvdata to load/store
operating mode for the regulator.

This change doesn't really add anything new.
It is just to make sure that the driver is in sync
with the current state of affairs in the hardware
instead of relying on locally stored status in the memory.

> > While at it, map fixed-frequency PWM regulators to REGULATOR_MODE_FAST.
> 
> Don't combine multiple changes into a single patch, this just makes
> everything harder to review.

Will split in v2.

Cheers,
Raag