linux-kernel - Re: [PATCH] gpio: delay: add OF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 5 Jun 2023 16:31:13 +0200
From:   Bartosz Golaszewski <brgl@...ev.pl>
To:     Arnd Bergmann <arnd@...nel.org>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        Alexander Stein <alexander.stein@...tq-group.com>,
        Arnd Bergmann <arnd@...db.de>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        William Breathitt Gray <william.gray@...aro.org>,
        Pandith N <pandith.n@...el.com>,
        Yinbo Zhu <zhuyinbo@...ngson.cn>,
        Niklas Schnelle <schnelle@...ux.ibm.com>,
        Nuno Sá <nuno.sa@...log.com>,
        Davide Ciminaghi <ciminaghi@...dd.com>,
        linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] gpio: delay: add OF_GPIO dependency

On Mon, Jun 5, 2023 at 1:02 PM Arnd Bergmann <arnd@...nel.org> wrote:
>
> From: Arnd Bergmann <arnd@...db.de>
>
> The new driver fails to build when OF_GPIO is disabled:
>
> drivers/gpio/gpio-delay.c: In function 'gpio_delay_of_xlate':
> drivers/gpio/gpio-delay.c:79:39: error: 'struct gpio_chip' has no member named 'of_gpio_n_cells'
>
> Fixes: cf5dec80c4e23 ("gpio: Add gpio delay driver")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  drivers/gpio/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> index a1dac1345f60f..006abaedcae82 100644
> --- a/drivers/gpio/Kconfig
> +++ b/drivers/gpio/Kconfig
> @@ -1735,6 +1735,7 @@ config GPIO_AGGREGATOR
>
>  config GPIO_DELAY
>         tristate "GPIO delay"
> +       depends on OF_GPIO
>         help
>           Say yes here to enable the GPIO delay, which provides a way to
>           configure platform specific delays for GPIO ramp-up or ramp-down
> --
> 2.39.2
>

Thanks, Alexander beat you to it.

Bart