linux-kernel - Re: [PATCH v2 1/5] block: Rework bio_for_each_segment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 6 Jun 2023 03:29:26 -0400
From:   Kent Overstreet <kent.overstreet@...ux.dev>
To:     Ming Lei <ming.lei@...hat.com>
Cc:     axboe@...nel.dk, linux-kernel@...r.kernel.org,
        linux-block@...r.kernel.org,
        Phillip Lougher <phillip@...ashfs.org.uk>
Subject: Re: [PATCH v2 1/5] block: Rework bio_for_each_segment_all()

On Tue, Jun 06, 2023 at 10:03:45AM +0800, Ming Lei wrote:
> On Mon, Jun 05, 2023 at 05:27:13PM -0400, Kent Overstreet wrote:
> > This patch reworks bio_for_each_segment_all() to be more inline with how
> > the other bio iterators work:
> > 
> >  - bio_iter_all_peek() now returns a synthesized bio_vec; we don't stash
> >    one in the iterator and pass a pointer to it - bad. This way makes it
> >    clearer what's a constructed value vs. a reference to something
> >    pre-existing, and it also will help with cleaning up and
> >    consolidating code with bio_for_each_folio_all().
> 
> by-value is more readable & clean, the current by-reference is just for aligning
> with original interface.

This is the fourth or fifth time this patch set has been out on the
list, and I specifically asked you to review it awhile back, and you're
just now looking at it?