[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <9db76b20dcd87d0406e8b26f14436431126d27fc.camel@mediatek.com>
Date: Thu, 8 Jun 2023 03:12:26 +0000
From: Shawn Sung (宋孝謙)
<Shawn.Sung@...iatek.com>
To: "p.zabel@...gutronix.de" <p.zabel@...gutronix.de>,
"matthias.bgg@...il.com" <matthias.bgg@...il.com>,
"krzysztof.kozlowski@...aro.org" <krzysztof.kozlowski@...aro.org>,
"angelogioacchino.delregno@...labora.com"
<angelogioacchino.delregno@...labora.com>,
"robh+dt@...nel.org" <robh+dt@...nel.org>,
"krzysztof.kozlowski+dt@...aro.org"
<krzysztof.kozlowski+dt@...aro.org>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-mediatek@...ts.infradead.org"
<linux-mediatek@...ts.infradead.org>,
Singo Chang (張興國)
<Singo.Chang@...iatek.com>,
"chunkuang.hu@...nel.org" <chunkuang.hu@...nel.org>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
Jason-JH Lin (林睿祥)
<Jason-JH.Lin@...iatek.com>,
Nancy Lin (林欣螢) <Nancy.Lin@...iatek.com>,
Project_Global_Chrome_Upstream_Group
<Project_Global_Chrome_Upstream_Group@...iatek.com>,
"fshao@...gle.com" <fshao@...gle.com>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v1 1/6] dt-bindings: display/mediatek: mt8188: Add
documentations for VDOSYS1
Hi Krzysztof,
Sorry, I missed this step in my SOP.
Will follow the instruction below to check again,
thank you for the information.
Best regards,
Hsiao Chien Sung
On Wed, 2023-06-07 at 09:26 +0200, Krzysztof Kozlowski wrote:
>
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
>
> On 07/06/2023 08:11, Hsiao Chien Sung wrote:
> > Add device tree documentations for MT8188 VDOSYS1.
>
> It does not look like you tested the bindings, at least after quick
> look. Please run `make dt_binding_check` (see
> Documentation/devicetree/bindings/writing-schema.rst for
> instructions).
> Maybe you need to update your dtschema and yamllint.
>
> > diff --git
> a/Documentation/devicetree/bindings/display/mediatek/mediatek,padding
> .yaml
> b/Documentation/devicetree/bindings/display/mediatek/mediatek,padding
> .yaml
> > new file mode 100644
> > index 000000000000..8a9e74cbf6dc
> > --- /dev/null
> > +++
> b/Documentation/devicetree/bindings/display/mediatek/mediatek,padding
> .yaml
> > @@ -0,0 +1,80 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id:
> http://devicetree.org/schemas/display/mediatek/mediatek,padding.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: MediaTek PADDING
> > +
> > +maintainers:
> > + - Chun-Kuang Hu <chunkuang.hu@...nel.org>
> > + - Philipp Zabel <p.zabel@...gutronix.de>
> > +
> > +description:
> > + MediaTek PADDING provides ability to VDOSYS1 to fill pixels to
> > + width and height of a layer with a specified color.
> > + Since MIXER in VDOSYS1 requires the width of a layer to be 2-
> pixel-align, or
> > + 4-pixel-align when ETHDR is enabled, we need PADDING to deal
> with odd width.
> > + Please notice that even if the PADDING is in bypass mode,
> > + settings in the registers must be cleared to 0, otherwise
> > + undeinfed behaviors could happen.
>
> Typo, undefined
>
> > +
>
>
>
> > +required:
> > + - compatible
> > + - reg
> > + - power-domains
> > + - clocks
> > + - mediatek,gce-client-reg
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > + - |
> > + #include <dt-bindings/interrupt-controller/arm-gic.h>
> > + #include <dt-bindings/clock/mt8188-clk.h>
> > + #include <dt-bindings/power/mt8188-power.h>
> > + #include <dt-bindings/gce/mt8188-gce.h>
> > + #include <dt-bindings/memory/mt8188-memory-port.h>
> > +
> > + soc {
> > + #address-cells = <2>;
> > + #size-cells = <2>;
> > +
> > + vdo1_padding0: vdo1_padding0@...1d000 {
>
> No underscores in node names.
>
> Node names should be generic. See also explanation and list of
> examples
> in DT specification:
>
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
>
> > + compatible = "mediatek,mt8188-vdo1-padding";
> > + reg = <0 0x1c11d000 0 0x1000>;
> > + clocks = <&vdosys1 CLK_VDO1_PADDING0>;
> > + power-domains = <&spm MT8188_POWER_DOMAIN_VDOSYS1>;
> > + mediatek,gce-client-reg =
> > + <&gce0 SUBSYS_1c11XXXX 0xd000 0x1000>;
>
> Wrong wrapping. It's one line. Properties should not be wrapped after
> '='.
>
>
> Best regards,
> Krzysztof
>
Powered by blists - more mailing lists