linux-kernel - Re: [PATCH 1/2] ASoC: dt-bindings: max98388: add amplifier driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87b9c96a-09bf-ec5d-85a0-65f59e5c593d@linaro.org>
Date:   Thu, 8 Jun 2023 09:18:28 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     “Ryan <ryan.lee.analog@...il.com>,
        lgirdwood@...il.com, broonie@...nel.org, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, perex@...ex.cz, tiwai@...e.com,
        rf@...nsource.cirrus.com, ryans.lee@...log.com,
        wangweidong.a@...nic.com, shumingf@...ltek.com,
        herve.codina@...tlin.com, ckeepax@...nsource.cirrus.com,
        doug@...morgal.com, ajye_huang@...pal.corp-partner.google.com,
        kiseok.jo@...ndevice.com, alsa-devel@...a-project.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     venkataprasad.potturu@....com
Subject: Re: [PATCH 1/2] ASoC: dt-bindings: max98388: add amplifier driver

On 08/06/2023 07:42, “Ryan wrote:
> From: Ryan Lee <ryans.lee@...log.com>
> 
> Add dt-bindings information for Analog Devices MAX98388 I2S Amplifier
> 
> Signed-off-by: Ryan Lee <ryans.lee@...log.com>

Thank you for your patch. There is something to discuss/improve.

> +
> +allOf:
> +  - $ref: dai-common.yaml#
> +
> +properties:
> +  compatible:
> +    enum:
> +      - adi,max98388

Blank line

> +  reg:
> +    maxItems: 1
> +    description: I2C address of the device.

Drop description, it's obvious.

> +
> +  '#sound-dai-cells':
> +    const: 0
> +
> +  adi,vmon-slot-no:
> +    description: slot number of the voltage feedback monitor
> +    $ref: "/schemas/types.yaml#/definitions/uint32"

Drop quotes.

> +    minimum: 0
> +    maximum: 15
> +    default: 0
> +
> +  adi,imon-slot-no:
> +    description: slot number of the current feedback monitor
> +    $ref: "/schemas/types.yaml#/definitions/uint32"

Drop quotes.

> +    minimum: 0
> +    maximum: 15
> +    default: 1
> +
> +  adi,interleave-mode:
> +    description:
> +      For cases where a single combined channel for the I/V feedback data
> +      is not sufficient, the device can also be configured to share
> +      a single data output channel on alternating frames.
> +      In this configuration, the current and voltage data will be frame
> +      interleaved on a single output channel.
> +    type: boolean
> +
> +  reset-gpios:
> +    maxItems: 1
> +
> +required:
> +  - compatible
> +  - reg
> +  - "#sound-dai-cells"

Keep consistent quotes - either ' or "

> +
> +unevaluatedProperties: false


Best regards,
Krzysztof