linux-kernel - Re: [PATCH 2/2] ASoC: max98388: add amplifier driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202306082054.jIU9oENf-lkp@intel.com>
Date:   Thu, 8 Jun 2023 20:21:12 +0800
From:   kernel test robot <lkp@...el.com>
To:     “Ryan <ryan.lee.analog@...il.com>,
        lgirdwood@...il.com, broonie@...nel.org, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, perex@...ex.cz, tiwai@...e.com,
        rf@...nsource.cirrus.com, ryans.lee@...log.com,
        wangweidong.a@...nic.com, shumingf@...ltek.com,
        herve.codina@...tlin.com, ckeepax@...nsource.cirrus.com,
        doug@...morgal.com, ajye_huang@...pal.corp-partner.google.com,
        kiseok.jo@...ndevice.com, alsa-devel@...a-project.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     oe-kbuild-all@...ts.linux.dev, venkataprasad.potturu@....com
Subject: Re: [PATCH 2/2] ASoC: max98388: add amplifier driver

Hi “Ryan,

kernel test robot noticed the following build warnings:

[auto build test WARNING on broonie-sound/for-next]
[also build test WARNING on linus/master v6.4-rc5 next-20230608]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Ryan/ASoC-max98388-add-amplifier-driver/20230608-134526
base:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
patch link:    https://lore.kernel.org/r/20230608054230.344014-2-ryan.lee.analog%40gmail.com
patch subject: [PATCH 2/2] ASoC: max98388: add amplifier driver
config: mips-allmodconfig (https://download.01.org/0day-ci/archive/20230608/202306082054.jIU9oENf-lkp@intel.com/config)
compiler: mips-linux-gcc (GCC) 12.3.0
reproduce (this is a W=1 build):
        mkdir -p ~/bin
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git remote add broonie-sound https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
        git fetch broonie-sound for-next
        git checkout broonie-sound/for-next
        b4 shazam https://lore.kernel.org/r/20230608054230.344014-2-ryan.lee.analog@gmail.com
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.3.0 ~/bin/make.cross W=1 O=build_dir ARCH=mips olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.3.0 ~/bin/make.cross W=1 O=build_dir ARCH=mips SHELL=/bin/bash sound/soc/codecs/

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202306082054.jIU9oENf-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> sound/soc/codecs/max98388.c:390:6: warning: no previous prototype for 'max98388_reset' [-Wmissing-prototypes]
     390 | void max98388_reset(struct max98388_priv *max98388, struct device *dev)
         |      ^~~~~~~~~~~~~~
>> sound/soc/codecs/max98388.c:904:6: warning: no previous prototype for 'max98388_read_deveice_property' [-Wmissing-prototypes]
     904 | void max98388_read_deveice_property(struct device *dev,
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~


vim +/max98388_reset +390 sound/soc/codecs/max98388.c

   389	
 > 390	void max98388_reset(struct max98388_priv *max98388, struct device *dev)
   391	{
   392		int ret, reg, count;
   393	
   394		/* Software Reset */
   395		ret = regmap_update_bits(max98388->regmap,
   396					 MAX98388_R2000_SW_RESET,
   397					 MAX98388_SOFT_RESET,
   398					 MAX98388_SOFT_RESET);
   399		if (ret)
   400			dev_err(dev, "Reset command failed. (ret:%d)\n", ret);
   401	
   402		count = 0;
   403		while (count < 3) {
   404			usleep_range(10000, 11000);
   405			/* Software Reset Verification */
   406			ret = regmap_read(max98388->regmap,
   407					  MAX98388_R22FF_REV_ID, &reg);
   408			if (!ret) {
   409				dev_info(dev, "Reset completed (retry:%d)\n", count);
   410				return;
   411			}
   412			count++;
   413		}
   414		dev_err(dev, "Reset failed. (ret:%d)\n", ret);
   415	}
   416	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki