linux-kernel - RE: [PATCH 1/2] ASoC: dt-bindings: max98388: add amplifier driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <SJ0PR03MB668141D0D4E9604E3670C34B8A51A@SJ0PR03MB6681.namprd03.prod.outlook.com>
Date:   Fri, 9 Jun 2023 23:52:20 +0000
From:   "Lee, RyanS" <RyanS.Lee@...log.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        “Ryan <ryan.lee.analog@...il.com>,
        "lgirdwood@...il.com" <lgirdwood@...il.com>,
        "broonie@...nel.org" <broonie@...nel.org>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "krzysztof.kozlowski+dt@...aro.org" 
        <krzysztof.kozlowski+dt@...aro.org>,
        "perex@...ex.cz" <perex@...ex.cz>,
        "tiwai@...e.com" <tiwai@...e.com>,
        "rf@...nsource.cirrus.com" <rf@...nsource.cirrus.com>,
        "wangweidong.a@...nic.com" <wangweidong.a@...nic.com>,
        "shumingf@...ltek.com" <shumingf@...ltek.com>,
        "herve.codina@...tlin.com" <herve.codina@...tlin.com>,
        "ckeepax@...nsource.cirrus.com" <ckeepax@...nsource.cirrus.com>,
        "doug@...morgal.com" <doug@...morgal.com>,
        "ajye_huang@...pal.corp-partner.google.com" 
        <ajye_huang@...pal.corp-partner.google.com>,
        "kiseok.jo@...ndevice.com" <kiseok.jo@...ndevice.com>,
        "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     "venkataprasad.potturu@....com" <venkataprasad.potturu@....com>
Subject: RE: [PATCH 1/2] ASoC: dt-bindings: max98388: add amplifier driver

> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> Sent: Thursday, June 8, 2023 12:18 AM
> To: “Ryan <ryan.lee.analog@...il.com>; lgirdwood@...il.com;
> broonie@...nel.org; robh+dt@...nel.org;
> krzysztof.kozlowski+dt@...aro.org; perex@...ex.cz; tiwai@...e.com;
> rf@...nsource.cirrus.com; Lee, RyanS <RyanS.Lee@...log.com>;
> wangweidong.a@...nic.com; shumingf@...ltek.com;
> herve.codina@...tlin.com; ckeepax@...nsource.cirrus.com;
> doug@...morgal.com; ajye_huang@...pal.corp-partner.google.com;
> kiseok.jo@...ndevice.com; alsa-devel@...a-project.org;
> devicetree@...r.kernel.org; linux-kernel@...r.kernel.org
> Cc: venkataprasad.potturu@....com
> Subject: Re: [PATCH 1/2] ASoC: dt-bindings: max98388: add amplifier driver
> 
> [External]
> 
> On 08/06/2023 07:42, “Ryan wrote:
> > From: Ryan Lee <ryans.lee@...log.com>
> >
> > Add dt-bindings information for Analog Devices MAX98388 I2S Amplifier
> >
> > Signed-off-by: Ryan Lee <ryans.lee@...log.com>
> 
> Thank you for your patch. There is something to discuss/improve.
Thanks for the comments. I shall fix the issues and submit the patch again.

> 
> > +
> > +allOf:
> > +  - $ref: dai-common.yaml#
> > +
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - adi,max98388
> 
> Blank line
> 
> > +  reg:
> > +    maxItems: 1
> > +    description: I2C address of the device.
> 
> Drop description, it's obvious.
> 
> > +
> > +  '#sound-dai-cells':
> > +    const: 0
> > +
> > +  adi,vmon-slot-no:
> > +    description: slot number of the voltage feedback monitor
> > +    $ref: "/schemas/types.yaml#/definitions/uint32"
> 
> Drop quotes.
> 
> > +    minimum: 0
> > +    maximum: 15
> > +    default: 0
> > +
> > +  adi,imon-slot-no:
> > +    description: slot number of the current feedback monitor
> > +    $ref: "/schemas/types.yaml#/definitions/uint32"
> 
> Drop quotes.
> 
> > +    minimum: 0
> > +    maximum: 15
> > +    default: 1
> > +
> > +  adi,interleave-mode:
> > +    description:
> > +      For cases where a single combined channel for the I/V feedback data
> > +      is not sufficient, the device can also be configured to share
> > +      a single data output channel on alternating frames.
> > +      In this configuration, the current and voltage data will be frame
> > +      interleaved on a single output channel.
> > +    type: boolean
> > +
> > +  reset-gpios:
> > +    maxItems: 1
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - "#sound-dai-cells"
> 
> Keep consistent quotes - either ' or "
> 
> > +
> > +unevaluatedProperties: false
> 
> 
> Best regards,
> Krzysztof