[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1eab400c-b568-3042-ebb6-e8244dee0149@starfivetech.com>
Date: Thu, 8 Jun 2023 20:17:02 +0800
From: Walker Chen <walker.chen@...rfivetech.com>
To: Mark Brown <broonie@...nel.org>
CC: Claudiu Beznea <Claudiu.Beznea@...rochip.com>,
Dan Carpenter <dan.carpenter@...aro.org>,
Liam Girdwood <lgirdwood@...il.com>,
Takashi Iwai <tiwai@...e.com>,
Jaroslav Kysela <perex@...ex.cz>,
<alsa-devel@...a-project.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1] ASoC: starfive: Cleanup and fix error check for JH7110
TDM
On 2023/6/8 18:50, Mark Brown wrote:
> On Thu, Jun 08, 2023 at 06:43:09PM +0800, Walker Chen wrote:
>> On 2023/6/8 18:15, Mark Brown wrote:
>
>> > I can't find the comments you're referring to in there.
>
>> You should see the following comments in the link above:
>
>> > + #define CLKPOL_BIT 5
>> > + #define TRITXEN_BIT 4
>> > + #define ELM_BIT 3
>> > + #define SYNCM_BIT 2
>> > + #define MS_BIT 1
>
>> Instead of these *_BIT defines as plain numbers you can defined them using
>> BIT() macro and use macros in place instead of
>
> The usual pattern is to have defines for both the shift and the mask,
> not just one.
OK, I see. It's not necessary to make these changes.
Thanks.
Best regards,
Walker
Powered by blists - more mailing lists