linux-kernel - Re: [PATCH v1] usb: dwc2: add pci_device_id driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2023060817-tinker-reaction-bbe1@gregkh>
Date:   Thu, 8 Jun 2023 11:11:09 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     zhuyinbo <zhuyinbo@...ngson.cn>
Cc:     Minas Harutyunyan <hminas@...opsys.com>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Alan Stern <stern@...land.harvard.edu>,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-pci@...r.kernel.org, Jianmin Lv <lvjianmin@...ngson.cn>,
        wanghongliang@...ngson.cn, Liu Peibao <liupeibao@...ngson.cn>,
        loongson-kernel@...ts.loongnix.cn
Subject: Re: [PATCH v1] usb: dwc2: add pci_device_id driver_data parse support

On Thu, Jun 08, 2023 at 04:57:04PM +0800, zhuyinbo wrote:
> 
> 
> 在 2023/6/8 下午4:01, Greg Kroah-Hartman 写道:
> > On Thu, Jun 08, 2023 at 03:54:36PM +0800, zhuyinbo wrote:
> > > 
> > > Friendly ping ?
> > 
> > For what?  I thought a new series was going to be submitted, I don't
> > have anything in my queue to review for this at the moment.
> 
> 
> I have some comments that need your consent or opinion.
> such as, I have a explanation why I using pci_match_id() in
> dwc2/params.c.  Do you agree with my explanation ?

I have no context here, sorry.  Remember, we review hundreds of patches
a week, when you cut off all context that makes it impossible to
remember.

Submit your updated patchset based on what you feel is correct and we
can review it from there.

thanks,

greg k-h