linux-kernel - Re: [PATCH] modpost: fix off by one in is_executable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK7LNATWmtiQdtvGLYL5b0Pyg4Bnmj0_Hn8xtWLzMJ_1oxkThA@mail.gmail.com>
Date:   Thu, 8 Jun 2023 23:55:55 +0900
From:   Masahiro Yamada <masahiroy@...nel.org>
To:     Dan Carpenter <dan.carpenter@...aro.org>
Cc:     Quentin Casasnovas <quentin.casasnovas@...cle.com>,
        Nathan Chancellor <nathan@...nel.org>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Nicolas Schier <nicolas@...sle.eu>,
        Rusty Russell <rusty@...tcorp.com.au>,
        linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] modpost: fix off by one in is_executable_section()

On Thu, Jun 8, 2023 at 6:15 PM Dan Carpenter <dan.carpenter@...aro.org> wrote:
>
> The > comparison should be >= to prevent an out of bounds array
> access.
>
> Fixes: 52dc0595d540 ("modpost: handle relocations mismatch in __ex_table.")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
> ---


Applied to linux-kbuild.
Thanks.



>  scripts/mod/modpost.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c
> index d10f5bdcb753..c3cb69c276ae 100644
> --- a/scripts/mod/modpost.c
> +++ b/scripts/mod/modpost.c
> @@ -1139,7 +1139,7 @@ static Elf_Sym *find_tosym(struct elf_info *elf, Elf_Addr addr, Elf_Sym *sym)
>
>  static bool is_executable_section(struct elf_info *elf, unsigned int secndx)
>  {
> -       if (secndx > elf->num_sections)
> +       if (secndx >= elf->num_sections)
>                 return false;
>
>         return (elf->sechdrs[secndx].sh_flags & SHF_EXECINSTR) != 0;
> --
> 2.39.2
>


-- 
Best Regards
Masahiro Yamada