linux-kernel - Re: [PATCH] leds: cht-wcove: set function cht_wc_leds_brightness

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230608145705.GN1930705@google.com>
Date:   Thu, 8 Jun 2023 15:57:05 +0100
From:   Lee Jones <lee@...nel.org>
To:     Tom Rix <trix@...hat.com>
Cc:     pavel@....cz, linux-leds@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] leds: cht-wcove: set function cht_wc_leds_brightness_get
 storage-class-specifier to static

On Tue, 30 May 2023, Tom Rix wrote:

> smatch reports
> drivers/leds/leds-cht-wcove.c:144:21: warning: symbol
>   'cht_wc_leds_brightness_get' was not declared. Should it be static?
> 
> This function is only used in its defining file, so it should be static.
> 
> Signed-off-by: Tom Rix <trix@...hat.com>
> ---
>  drivers/leds/leds-cht-wcove.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Sorry, you were pipped to the post:

https://lore.kernel.org/r/20230525183317.129232-1-hdegoede@redhat.com

-- 
Lee Jones [李琼斯]