linux-kernel - Re: [PATCH v2] dt-bindings: riscv: deprecate riscv,isa

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230609-glamour-immovable-4211c564745d@wendy>
Date:   Fri, 9 Jun 2023 15:20:09 +0100
From:   Conor Dooley <conor.dooley@...rochip.com>
To:     Rob Herring <robh@...nel.org>
CC:     Conor Dooley <conor@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Oleksii <oleksii.kurochko@...il.com>,
        Anup Patel <apatel@...tanamicro.com>, <qemu-riscv@...gnu.org>,
        <u-boot@...ts.denx.de>, Andrew Jones <ajones@...tanamicro.com>,
        <palmer@...belt.com>, Atish Patra <atishp@...shpatra.org>,
        Jessica Clarke <jrtc27@...c27.com>,
        Paul Walmsley <paul.walmsley@...ive.com>,
        Alistair Francis <alistair.francis@....com>,
        <devicetree@...r.kernel.org>, <linux-riscv@...ts.infradead.org>,
        Rick Chen <rick@...estech.com>, <linux-kernel@...r.kernel.org>,
        Leo <ycliang@...estech.com>
Subject: Re: [PATCH v2] dt-bindings: riscv: deprecate riscv,isa

On Fri, Jun 09, 2023 at 08:03:44AM -0600, Rob Herring wrote:

> Nope, vendor prefixes don't go in node names. That's not explicit
> anywhere, but goes against using generic node names.

Yeah, that makes sense.

> Also, note that looking at the DT spec, there's already prior art here
> with PPC. See "power-isa-*". Though that appears in .dts files, but no
> kernel code. Maybe you already saw that as your v1 is similar. There's
> not really much advantage to align with it, but also not much reason
> to deviate.

I went back and forth on riscv-isa- versus riscv,isa-, picking the , for
consistency with other properties in the file. I thought that doing it
like power would be frowned upon & that it might've been done like that
for historic reasons, especially given existing properties we have for
riscv ISA related things are vendor properties w/ the comma.

I don't have strong feelings either way though, so if you say s/,/-/
then that's good by me!

Cheers,
Conor.

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)