linux-kernel - Re: [PATCH V2] dt-bindings: reset: convert the xlnx,zynqmp-reset.txt to yaml

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 9 Jun 2023 17:38:42 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Piyush Mehta <piyush.mehta@....com>, p.zabel@...gutronix.de,
        robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
        conor+dt@...nel.org, michal.simek@....com, michal.simek@...inx.com,
        nava.manne@...inx.com
Cc:     linux-usb@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, siva.durga.prasad.paladugu@....com,
        git@....com
Subject: Re: [PATCH V2] dt-bindings: reset: convert the xlnx,zynqmp-reset.txt
 to yaml

On 09/06/2023 13:04, Piyush Mehta wrote:
> Convert the binding to DT schema format. It also updates the
> reset-controller description.
> 
> Signed-off-by: Piyush Mehta <piyush.mehta@....com>
> ---
> - Addressed the Krzysztof review comment:
>  - Update DT binding to fix the dt_binding_check warning.
> 

...

> diff --git a/Documentation/devicetree/bindings/reset/xlnx,zynqmp-reset.yaml b/Documentation/devicetree/bindings/reset/xlnx,zynqmp-reset.yaml
> new file mode 100644
> index 000000000000..a39b17599e05
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/reset/xlnx,zynqmp-reset.yaml
> @@ -0,0 +1,64 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/reset/xlnx,zynqmp-reset.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Zynq UltraScale+ MPSoC and Versal reset binding

Drop "binding"

> +
> +maintainers:
> +  - Piyush Mehta <piyush.mehta@....com>
> +
> +description: |
> +  The Zynq UltraScale+ MPSoC and Versal has several different resets.
> +
> +  The PS reset subsystem is responsible for handling the external reset
> +  input to the device and that all internal reset requirements are met
> +  for the system (as a whole) and for the functional units.
> +
> +  Please also refer to reset.txt in this directory for common reset
> +  controller binding usage. Device nodes that need access to reset
> +  lines should specify them as a reset phandle in their corresponding
> +  node as specified in reset.txt.
> +
> +  For list of all valid reset indices for Zynq UltraScale+ MPSoC
> +  <dt-bindings/reset/xlnx-zynqmp-resets.h>
> +
> +  For list of all valid reset indices for Versal
> +  <dt-bindings/reset/xlnx-versal-resets.h>
> +
> +properties:
> +  compatible:
> +    enum:
> +      - xlnx,zynqmp-reset
> +      - xlnx,versal-reset
> +
> +  "#reset-cells":
> +    const: 1
> +
> +required:
> +  - compatible
> +  - "#reset-cells"
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/reset/xlnx-zynqmp-resets.h>

Drop, won't be needed after removing unrelated parts.

> +
> +    firmware {

Drop

> +        zynqmp_firmware: zynqmp-firmware {

Drop, three level of indentations for that simple reset-controller...

> +            zynqmp_reset: reset-controller {
> +                compatible = "xlnx,zynqmp-reset";
> +                #reset-cells = <1>;
> +            };
> +        };
> +    };
> +
> +    /* Specifying sata reset control of devices */
> +    sata {
> +        resets = <&zynqmp_reset ZYNQMP_RESET_SATA>;
> +        reset-names = "sata_rst";
> +    };

Drop this - not related.
> +
> +...

Best regards,
Krzysztof