linux-kernel - Re: [PATCH v2 3/3] PCI: qcom-ep: Add ICC bandwidth voting support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230609165826.GA1251610@bhelgaas>
Date:   Fri, 9 Jun 2023 11:58:26 -0500
From:   Bjorn Helgaas <helgaas@...nel.org>
To:     Krishna Chaitanya Chundru <quic_krichai@...cinc.com>
Cc:     manivannan.sadhasivam@...aro.org, quic_vbadigan@...cinc.com,
        quic_ramkri@...cinc.com, Manivannan Sadhasivam <mani@...nel.org>,
        Lorenzo Pieralisi <lpieralisi@...nel.org>,
        Krzysztof Wilczyński <kw@...ux.com>,
        Rob Herring <robh@...nel.org>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        "open list:PCIE ENDPOINT DRIVER FOR QUALCOMM" 
        <linux-pci@...r.kernel.org>,
        "open list:PCIE ENDPOINT DRIVER FOR QUALCOMM" 
        <linux-arm-msm@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 3/3] PCI: qcom-ep: Add ICC bandwidth voting support

On Fri, Jun 09, 2023 at 05:22:00PM +0530, Krishna Chaitanya Chundru wrote:
> On 6/7/2023 10:13 PM, Bjorn Helgaas wrote:
> > On Wed, Jun 07, 2023 at 09:48:07PM +0530, Krishna chaitanya chundru wrote:
> > > Add support to vote for ICC bandwidth based on the link
> > > speed and width.

> > This plus the pcie_ep->icc init below is basically identical to
> > qcom_pcie_icc_init() in pcie_qcom.c.  Why not use the same structure
> > here, with a qcom_pcie_icc_init() function?  It's better to be the
> > same than different (when possible, of course).
> 
> In pcie_qcom.c driver the resources will be turned on the probe itself.
> 
> But in pcie-qcom-ep.c driver will wait for the host to toggle the perst to
> enable all the resources
> 
> that is reason it is different here.

Understood, differences like this do make sense.  It's not always
possible, but when it is, it's helpful to use similar structure and
function names because it makes it easier to understand and easier to
see opportunities for refactoring.

Bjorn