linux-kernel - Re: [PATCH v11 4/8] arm64: ftrace: Enable HAVE_FUNCTION_GRAPH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230609131924.5ff89413@gandalf.local.home>
Date:   Fri, 9 Jun 2023 13:19:24 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Catalin Marinas <catalin.marinas@....com>
Cc:     Donglin Peng <pengdonglin@...gfor.com.cn>, mhiramat@...nel.org,
        linux@...linux.org.uk, mark.rutland@....com, will@...nel.org,
        rmk+kernel@...linux.org.uk, palmer@...belt.com,
        paul.walmsley@...ive.com, aou@...s.berkeley.edu,
        tglx@...utronix.de, dave.hansen@...ux.intel.com, x86@...nel.org,
        bp@...en8.de, hpa@...or.com, chenhuacai@...nel.org,
        zhangqing@...ngson.cn, kernel@...0n.name, mingo@...hat.com,
        peterz@...radead.org, xiehuan09@...il.com, dinghui@...gfor.com.cn,
        huangcun@...gfor.com.cn, dolinux.peng@...il.com,
        linux-trace-kernel@...r.kernel.org, loongarch@...ts.linux.dev,
        linux-riscv@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v11 4/8] arm64: ftrace: Enable
 HAVE_FUNCTION_GRAPH_RETVAL

On Fri, 9 Jun 2023 10:31:19 +0100
Catalin Marinas <catalin.marinas@....com> wrote:

> On Sat, Apr 08, 2023 at 05:42:18AM -0700, Donglin Peng wrote:
> > The previous patch ("function_graph: Support recording and printing
> > the return value of function") has laid the groundwork for the for
> > the funcgraph-retval, and this modification makes it available on
> > the ARM64 platform.
> > 
> > We introduce a new structure called fgraph_ret_regs for the ARM64
> > platform to hold return registers and the frame pointer. We then
> > fill its content in the return_to_handler and pass its address to
> > the function ftrace_return_to_handler to record the return value.
> > 
> > Reviewed-by: Mark Rutland <mark.rutland@....com>
> > Tested-by: Mark Rutland <mark.rutland@....com>
> > Signed-off-by: Donglin Peng <pengdonglin@...gfor.com.cn>  
> 
> We fully trust Mark's reviews ;) but just in case you need an official
> maintainer ack:
> 
> Acked-by: Catalin Marinas <catalin.marinas@....com>

Thanks Catalin, that does help.

-- Steve