linux-kernel - Re: [PATCH 1/1] cdrom: Fix spectre-v1 gadget

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 10 Jun 2023 01:19:34 +0800
From:   kernel test robot <lkp@...el.com>
To:     Jordy Zomer <jordyzomer@...gle.com>, linux-kernel@...r.kernel.org
Cc:     oe-kbuild-all@...ts.linux.dev, phil@...lpotter.co.uk,
        Jordy Zomer <jordyzomer@...gle.com>
Subject: Re: [PATCH 1/1] cdrom: Fix spectre-v1 gadget

Hi Jordy,

kernel test robot noticed the following build errors:

[auto build test ERROR on linus/master]
[also build test ERROR on v6.4-rc5 next-20230609]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Jordy-Zomer/cdrom-Fix-spectre-v1-gadget/20230609-211545
base:   linus/master
patch link:    https://lore.kernel.org/r/20230609131355.71130-2-jordyzomer%40google.com
patch subject: [PATCH 1/1] cdrom: Fix spectre-v1 gadget
config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20230610/202306100143.yzdJpUid-lkp@intel.com/config)
compiler: alpha-linux-gcc (GCC) 12.3.0
reproduce (this is a W=1 build):
        mkdir -p ~/bin
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git checkout linus/master
        b4 shazam https://lore.kernel.org/r/20230609131355.71130-2-jordyzomer@google.com
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.3.0 ~/bin/make.cross W=1 O=build_dir ARCH=alpha olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.3.0 ~/bin/make.cross W=1 O=build_dir ARCH=alpha SHELL=/bin/bash drivers/

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202306100143.yzdJpUid-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/cdrom/cdrom.c: In function 'cdrom_ioctl_media_changed':
>> drivers/cdrom/cdrom.c:2333:15: error: implicit declaration of function 'array_index_mask_nospec' [-Werror=implicit-function-declaration]
    2333 |         arg = array_index_mask_nospec(arg, cdi->capacity);
         |               ^~~~~~~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors


vim +/array_index_mask_nospec +2333 drivers/cdrom/cdrom.c

  2314	
  2315	static int cdrom_ioctl_media_changed(struct cdrom_device_info *cdi,
  2316			unsigned long arg)
  2317	{
  2318		struct cdrom_changer_info *info;
  2319		int ret;
  2320	
  2321		cd_dbg(CD_DO_IOCTL, "entering CDROM_MEDIA_CHANGED\n");
  2322	
  2323		if (!CDROM_CAN(CDC_MEDIA_CHANGED))
  2324			return -ENOSYS;
  2325	
  2326		/* cannot select disc or select current disc */
  2327		if (!CDROM_CAN(CDC_SELECT_DISC) || arg == CDSL_CURRENT)
  2328			return media_changed(cdi, 1);
  2329	
  2330		if (arg >= cdi->capacity)
  2331			return -EINVAL;
  2332	
> 2333		arg = array_index_mask_nospec(arg, cdi->capacity);
  2334	
  2335		info = kmalloc(sizeof(*info), GFP_KERNEL);
  2336		if (!info)
  2337			return -ENOMEM;
  2338	
  2339		ret = cdrom_read_mech_status(cdi, info);
  2340		if (!ret)
  2341			ret = info->slots[arg].change;
  2342		kfree(info);
  2343		return ret;
  2344	}
  2345	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki