linux-kernel - Re: [PATCH] Enable AMD3255 Proc to show negative temperature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <332b83a8-779f-73a6-8113-50f59c7e7184@infradead.org>
Date:   Fri, 9 Jun 2023 16:30:11 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Baskaran Kannan <Baski.Kannan@....com>, Mario.Limonciello@....com,
        babu.moger@....com, clemens@...isch.de, jdelvare@...e.com,
        linux@...ck-us.net, linux-hwmon@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Enable AMD3255 Proc to show negative temperature

Hi--

Style issues:

On 6/9/23 16:11, Baskaran Kannan wrote:
> From: Your Name <you@...mple.com>

Fix that. ^^^^^

Provide a comment message (not empty).

> 
> Signed-off-by: Baski Kannan <Baski.Kannan@....com>
> ---
>  drivers/hwmon/k10temp.c | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
> 
> diff --git a/drivers/hwmon/k10temp.c b/drivers/hwmon/k10temp.c
> index 489ad0b1bc74..58e4d90de5e3 100644
> --- a/drivers/hwmon/k10temp.c
> +++ b/drivers/hwmon/k10temp.c
> @@ -77,6 +77,11 @@ static DEFINE_MUTEX(nb_smu_ind_mutex);
>  #define ZEN_CUR_TEMP_RANGE_SEL_MASK		BIT(19)
>  #define ZEN_CUR_TEMP_TJ_SEL_MASK		GENMASK(17, 16)
>  
> +/* AMD's Industrial processor 3255 supports temperature from -40 deg to 105 deg Celsius.
> + * Do not round off to zero for negative Tctl or Tdie values
> + */

Linux multi-line coding style (except for net/ and bpf/) is like:

/*
 * AMD's Industrial processor 3255 supports temperature from -40 deg to 105 deg Celsius.
 * Do not round off to zero for negative Tctl or Tdie values
 */

End the last sentence above with a period.


> +#define AMD_I3255_STR				"3255"
> +
>  struct k10temp_data {
>  	struct pci_dev *pdev;
>  	void (*read_htcreg)(struct pci_dev *pdev, u32 *regval);


For the next patch version, please make sure that it says v2
and explain the differences in v1 and v2.

thanks.
-- 
~Randy