linux-kernel - Re: [PATCH v2 1/1] gpiolib: Do not unexport GPIO on freeing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdayWaSTAP3Us6_3O0qy8SqOY35d5AfD7EyVkdFkGegs3g@mail.gmail.com>
Date:   Fri, 9 Jun 2023 09:23:16 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     Bartosz Golaszewski <bartosz.golaszewski@...aro.org>,
        linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
        Bartosz Golaszewski <brgl@...ev.pl>
Subject: Re: [PATCH v2 1/1] gpiolib: Do not unexport GPIO on freeing

On Mon, Jun 5, 2023 at 2:58 PM Andy Shevchenko
<andriy.shevchenko@...ux.intel.com> wrote:

> Since the legacy exporting is gone with 2f804aca4832 ("gpiolib:
> Kill unused GPIOF_EXPORT and Co") there is no need to unexport
> GPIO on freeing. Remove that call.
>
> Note, the other users of this functionality do that explicitly,
> except one SH and one OMAP boardfile which don't free GPIO anyways,
> so it is safe to drop the call.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

Yeah let's kill this off it is just annoying.
Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij