linux-kernel - Re: [PATCH v2 1/1] gpiolib: Do not unexport GPIO on freeing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMRc=Mf_TamPbL2m2RnV9NNwXKe=P=7cbZy0YJkFw6e=L64xNg@mail.gmail.com>
Date:   Fri, 9 Jun 2023 11:38:59 +0200
From:   Bartosz Golaszewski <brgl@...ev.pl>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     Bartosz Golaszewski <bartosz.golaszewski@...aro.org>,
        linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
        Linus Walleij <linus.walleij@...aro.org>
Subject: Re: [PATCH v2 1/1] gpiolib: Do not unexport GPIO on freeing

On Mon, Jun 5, 2023 at 2:58 PM Andy Shevchenko
<andriy.shevchenko@...ux.intel.com> wrote:
>
> Since the legacy exporting is gone with 2f804aca4832 ("gpiolib:
> Kill unused GPIOF_EXPORT and Co") there is no need to unexport
> GPIO on freeing. Remove that call.
>
> Note, the other users of this functionality do that explicitly,
> except one SH and one OMAP boardfile which don't free GPIO anyways,
> so it is safe to drop the call.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
> v2: mentioned OMAP boardfile as well
>  drivers/gpio/gpiolib.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
> index a8da38ee721a..7a9c9934365a 100644
> --- a/drivers/gpio/gpiolib.c
> +++ b/drivers/gpio/gpiolib.c
> @@ -2117,8 +2117,6 @@ static bool gpiod_free_commit(struct gpio_desc *desc)
>
>         might_sleep();
>
> -       gpiod_unexport(desc);
> -
>         spin_lock_irqsave(&gpio_lock, flags);
>
>         gc = desc->gdev->chip;
> --
> 2.40.0.1.gaa8946217a0b
>

Ah, you already sent a v2. I applied this one.

Bart