linux-kernel - Re: [PATCH v1 1/1] gpiolib: Do not unexport GPIO on freeing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMRc=Me+GnmrJH10sc9wCdsVpLnW-ksd4VjgHKPr8+v3K6jjPA@mail.gmail.com>
Date:   Fri, 9 Jun 2023 11:35:08 +0200
From:   Bartosz Golaszewski <brgl@...ev.pl>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     Bartosz Golaszewski <bartosz.golaszewski@...aro.org>,
        linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
        Linus Walleij <linus.walleij@...aro.org>
Subject: Re: [PATCH v1 1/1] gpiolib: Do not unexport GPIO on freeing

On Fri, Jun 2, 2023 at 6:34 PM Andy Shevchenko
<andriy.shevchenko@...ux.intel.com> wrote:
>
> On Fri, Jun 02, 2023 at 07:29:00PM +0300, Andy Shevchenko wrote:
> > On Fri, Jun 02, 2023 at 07:22:58PM +0300, Andy Shevchenko wrote:
> > > Since the legacy exporting is gone with 2f804aca4832 ("gpiolib:
> > > Kill unused GPIOF_EXPORT and Co") there is no need to unexport
> > > GPIO on freeing. Remove that call.
>
> > > Note, the other users of this functionality do that explicitly,
> > > except one SH boardfile which doesn't free GPIO anyways, so it
>
> Actually OMAP3 as well with the same idea, once requested those never freed.
> Bart, should I update the commit message?
>
> > > is safe to drop the call.
> >
> > Note, that this might be squashed with the above mentioned commit, because
> > I haven't checked current users I didn't do the removal in that patch.
> >
> > But this will probably needs rebase which is not good thing process wise.
> > So, just my 2 cents in case.
>
> --
> With Best Regards,
> Andy Shevchenko
>
>

I did it myself when applying, thanks!

Bart