linux-kernel - [PATCH] EDAC/amd64: set variable gpu_node_map storage-class-specifier to static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 10 Jun 2023 17:09:30 -0400
From:   Tom Rix <trix@...hat.com>
To:     yazen.ghannam@....com, bp@...en8.de, tony.luck@...el.com,
        james.morse@....com, mchehab@...nel.org, rric@...nel.org
Cc:     linux-edac@...r.kernel.org, linux-kernel@...r.kernel.org,
        Tom Rix <trix@...hat.com>
Subject: [PATCH] EDAC/amd64: set variable gpu_node_map storage-class-specifier to static

smatch reports
drivers/edac/amd64_edac.c:990:3: warning: symbol
  'gpu_node_map' was not declared. Should it be static?

This variable is only used in its defining file, so it should be static.

Signed-off-by: Tom Rix <trix@...hat.com>
---
 drivers/edac/amd64_edac.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/edac/amd64_edac.c b/drivers/edac/amd64_edac.c
index 5d7c080d96a2..597dae7692b1 100644
--- a/drivers/edac/amd64_edac.c
+++ b/drivers/edac/amd64_edac.c
@@ -984,7 +984,7 @@ static int sys_addr_to_csrow(struct mem_ctl_info *mci, u64 sys_addr)
  * system and what the lowest AMD Node ID value is for the GPU nodes. Use this
  * info to fixup the Linux logical "Node ID" value set in the AMD NB code and EDAC.
  */
-struct local_node_map {
+static struct local_node_map {
 	u16 node_count;
 	u16 base_node_id;
 } gpu_node_map;
-- 
2.27.0