linux-kernel - Re: [PATCH] EDAC/amd64: set variable gpu_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <89a67e4d-cada-ff57-f702-d5579ea8b39c@amd.com>
Date:   Wed, 14 Jun 2023 11:21:46 -0400
From:   Yazen Ghannam <yazen.ghannam@....com>
To:     Tom Rix <trix@...hat.com>, bp@...en8.de, tony.luck@...el.com,
        james.morse@....com, mchehab@...nel.org, rric@...nel.org
Cc:     yazen.ghannam@....com, linux-edac@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] EDAC/amd64: set variable gpu_node_map
 storage-class-specifier to static

On 6/10/2023 5:09 PM, Tom Rix wrote:
> smatch reports
> drivers/edac/amd64_edac.c:990:3: warning: symbol
>    'gpu_node_map' was not declared. Should it be static?
> 
> This variable is only used in its defining file, so it should be static.
> 

Hi Tom,

Please use "imperative mood" when describing the change.

"This variable is only used in its defining file, so add the 'static' 
keyword to it."

or

"Make gpu_node_map static, since it's only used in its defining file."

Also, would a Fixes tag be appropriate?

Otherwise, looks good to me.

Reviewed-by: Yazen Ghannam <yazen.ghannam@....com>

Thanks,
Yazen