linux-kernel - RE: [PATCH v2 01/38] backlight/bd6107: Compare against struct fb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <IA1PR11MB641822AFCB0E0EA5856C7E59C154A@IA1PR11MB6418.namprd11.prod.outlook.com>
Date:   Mon, 12 Jun 2023 15:17:43 +0000
From:   "Ruhl, Michael J" <michael.j.ruhl@...el.com>
To:     Thomas Zimmermann <tzimmermann@...e.de>,
        "daniel@...ll.ch" <daniel@...ll.ch>,
        "javierm@...hat.com" <javierm@...hat.com>,
        "sam@...nborg.org" <sam@...nborg.org>,
        "deller@....de" <deller@....de>,
        "geert+renesas@...der.be" <geert+renesas@...der.be>,
        "lee@...nel.org" <lee@...nel.org>,
        "daniel.thompson@...aro.org" <daniel.thompson@...aro.org>,
        "jingoohan1@...il.com" <jingoohan1@...il.com>,
        "dan.carpenter@...aro.org" <dan.carpenter@...aro.org>
CC:     "linux-fbdev@...r.kernel.org" <linux-fbdev@...r.kernel.org>,
        "Laurent Pinchart" <laurent.pinchart+renesas@...asonboard.com>,
        "linux-sh@...r.kernel.org" <linux-sh@...r.kernel.org>,
        "linux-staging@...ts.linux.dev" <linux-staging@...ts.linux.dev>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>,
        "linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>
Subject: RE: [PATCH v2 01/38] backlight/bd6107: Compare against struct
 fb_info.device


>-----Original Message-----
>From: dri-devel <dri-devel-bounces@...ts.freedesktop.org> On Behalf Of
>Thomas Zimmermann
>Sent: Monday, June 12, 2023 10:08 AM
>To: daniel@...ll.ch; javierm@...hat.com; sam@...nborg.org;
>deller@....de; geert+renesas@...der.be; lee@...nel.org;
>daniel.thompson@...aro.org; jingoohan1@...il.com;
>dan.carpenter@...aro.org; Ruhl, Michael J <michael.j.ruhl@...el.com>
>Cc: linux-fbdev@...r.kernel.org; Laurent Pinchart
><laurent.pinchart+renesas@...asonboard.com>; linux-sh@...r.kernel.org;
>linux-staging@...ts.linux.dev; linux-kernel@...r.kernel.org; dri-
>devel@...ts.freedesktop.org; stable@...r.kernel.org; Thomas Zimmermann
><tzimmermann@...e.de>; linux-omap@...r.kernel.org
>Subject: [PATCH v2 01/38] backlight/bd6107: Compare against struct
>fb_info.device
>
>Struct bd6107_platform_data refers to a platform device within
>the Linux device hierarchy. The test in bd6107_backlight_check_fb()
>compares it against the fbdev device in struct fb_info.dev, which
>is different. Fix the test by comparing to struct fb_info.device.
>
>Fixes a bug in the backlight driver and prepares fbdev for making
>struct fb_info.dev optional.
>
>v2:
>	* move renames into separate patch (Javier, Sam, Michael)
>
>Fixes: 67b43e590415 ("backlight: Add ROHM BD6107 backlight driver")
>Signed-off-by: Thomas Zimmermann <tzimmermann@...e.de>
>Cc: Laurent Pinchart <laurent.pinchart+renesas@...asonboard.com>
>Cc: Lee Jones <lee@...nel.org>
>Cc: Daniel Thompson <daniel.thompson@...aro.org>
>Cc: Jingoo Han <jingoohan1@...il.com>
>Cc: dri-devel@...ts.freedesktop.org
>Cc: <stable@...r.kernel.org> # v3.12+
>Reviewed-by: Javier Martinez Canillas <javierm@...hat.com>
>---
> drivers/video/backlight/bd6107.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/video/backlight/bd6107.c
>b/drivers/video/backlight/bd6107.c
>index f4db6c064635b..e3410444ea235 100644
>--- a/drivers/video/backlight/bd6107.c
>+++ b/drivers/video/backlight/bd6107.c
>@@ -104,7 +104,7 @@ static int bd6107_backlight_check_fb(struct
>backlight_device *backlight,
> {
> 	struct bd6107 *bd = bl_get_data(backlight);
>
>-	return bd->pdata->fbdev == NULL || bd->pdata->fbdev == info->dev;
>+	return bd->pdata->fbdev == NULL || bd->pdata->fbdev == info->device;

Thomas,

Looking at the fb.h file I see:

	struct device *device;		/* This is the parent */
	struct device *dev;		/* This is this fb device */

Is this documentation "correct"?  If so, how does that match what you are doing here?

Thanks,

M

> }
>
> static const struct backlight_ops bd6107_backlight_ops = {
>--
>2.41.0