linux-kernel - Re: [PATCH] mm/khugepaged: use DEFINE_READ_MOSTLY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHbLzkr4cf7XqsCR29_-qLysuELaaFvThJ3eoNd-nvkhVdKrYg@mail.gmail.com>
Date:   Mon, 12 Jun 2023 14:59:28 -0700
From:   Yang Shi <shy828301@...il.com>
To:     ndesaulniers@...gle.com
Cc:     Andrew Morton <akpm@...ux-foundation.org>, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm/khugepaged: use DEFINE_READ_MOSTLY_HASHTABLE macro

On Fri, Jun 9, 2023 at 4:44 PM <ndesaulniers@...gle.com> wrote:
>
> These are equivalent, but DEFINE_READ_MOSTLY_HASHTABLE exists to define
> a hashtable in the .data..read_mostly section.
>
> Signed-off-by: Nick Desaulniers <ndesaulniers@...gle.com>

Reviewed-by: Yang Shi <shy828301@...il.com>

> ---
>  mm/khugepaged.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/khugepaged.c b/mm/khugepaged.c
> index 6b9d39d65b73..e7dc49214413 100644
> --- a/mm/khugepaged.c
> +++ b/mm/khugepaged.c
> @@ -88,7 +88,7 @@ static unsigned int khugepaged_max_ptes_swap __read_mostly;
>  static unsigned int khugepaged_max_ptes_shared __read_mostly;
>
>  #define MM_SLOTS_HASH_BITS 10
> -static __read_mostly DEFINE_HASHTABLE(mm_slots_hash, MM_SLOTS_HASH_BITS);
> +static DEFINE_READ_MOSTLY_HASHTABLE(mm_slots_hash, MM_SLOTS_HASH_BITS);
>
>  static struct kmem_cache *mm_slot_cache __read_mostly;
>
>
> ---
> base-commit: 64569520920a3ca5d456ddd9f4f95fc6ea9b8b45
> change-id: 20230609-khugepage-09ea340b378e
>
> Best regards,
> --
> Nick Desaulniers <ndesaulniers@...gle.com>
>
>