linux-kernel - Re: [PATCH v1] iio: ado: ad7192: Add error check and more debug log

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b38cb68185b078fe346727b6dceb17967a56c18a.camel@gmail.com>
Date:   Tue, 13 Jun 2023 10:19:38 +0200
From:   Nuno Sá <noname.nuno@...il.com>
To:     Markus Burri <markus.burri@...com>, linux-kernel@...r.kernel.org
Cc:     Alexandru Tachici <alexandru.tachici@...log.com>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Michael Hennerich <Michael.Hennerich@...log.com>,
        Jonathan Cameron <jic23@...nel.org>, linux-iio@...r.kernel.org
Subject: Re: [PATCH v1] iio: ado: ad7192: Add error check and more debug log

On Tue, 2023-06-13 at 07:42 +0200, Markus Burri wrote:
> Print read and expected device ID as debug warning.
> Add error check for ad_sd_init() result.
> 
> Signed-off-by: Markus Burri <markus.burri@...com>
> ---

You have unrelated changes but they are easy enough to go in same patch
(at least for me). Hence:

Reviewed-by: Nuno Sa <nuno.sa@...log.com>

>  drivers/iio/adc/ad7192.c | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/iio/adc/ad7192.c b/drivers/iio/adc/ad7192.c
> index d71977b..220c3b7 100644
> --- a/drivers/iio/adc/ad7192.c
> +++ b/drivers/iio/adc/ad7192.c
> @@ -403,8 +403,8 @@ static int ad7192_setup(struct ad7192_state *st, struct
> device_node *np)
>         id &= AD7192_ID_MASK;
>  
>         if (id != st->chip_info->chip_id)
> -               dev_warn(&st->sd.spi->dev, "device ID query failed (0x%X)\n",
> -                        id);
> +               dev_warn(&st->sd.spi->dev, "device ID query failed (0x%X !=
> 0x%X)\n",
> +                        id, st->chip_info->chip_id);
>  
>         st->mode = AD7192_MODE_SEL(AD7192_MODE_IDLE) |
>                 AD7192_MODE_CLKSRC(st->clock_sel) |
> @@ -1049,7 +1049,9 @@ static int ad7192_probe(struct spi_device *spi)
>         else
>                 indio_dev->info = &ad7192_info;
>  
> -       ad_sd_init(&st->sd, indio_dev, spi, &ad7192_sigma_delta_info);
> +       ret = ad_sd_init(&st->sd, indio_dev, spi, &ad7192_sigma_delta_info);
> +       if (ret)
> +               return ret;
>  
>         ret = devm_ad_sd_setup_buffer_and_trigger(&spi->dev, indio_dev);
>         if (ret)