linux-kernel - Re: [PATCH v4 11/11] blksnap: Kconfig and Makefile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7dbbaf60-c85d-5a7a-8f16-5f5e4ff43cd8@veeam.com>
Date:   Tue, 13 Jun 2023 12:47:29 +0200
From:   Sergei Shtepa <sergei.shtepa@...am.com>
To:     Randy Dunlap <rdunlap@...radead.org>, <axboe@...nel.dk>,
        <hch@...radead.org>, <corbet@....net>, <snitzer@...nel.org>
CC:     <viro@...iv.linux.org.uk>, <brauner@...nel.org>,
        <willy@...radead.org>, <dlemoal@...nel.org>, <wsa@...nel.org>,
        <heikki.krogerus@...ux.intel.com>, <ming.lei@...hat.com>,
        <gregkh@...uxfoundation.org>, <linux-block@...r.kernel.org>,
        <linux-doc@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-fsdevel@...r.kernel.org>
Subject: Re: [PATCH v4 11/11] blksnap: Kconfig and Makefile



On 6/13/23 01:43, Randy Dunlap wrote:
>> +config BLKSNAP
>> +	tristate "Block Devices Snapshots Module (blksnap)"
>> +	help
>> +	  Allow to create snapshots and track block changes for block devices.
>> +	  Designed for creating backups for simple block devices. Snapshots are
>> +	  temporary and are released then backup is completed. Change block
> 	                             when backup is completed.
> 
> or is the order of operations as listed: release snapshots and then backup
> can be completed?
> 
>> +	  tracking allows to create incremental or differential backups.

"when backup is completed." - it will be more correct.

Normal backup process:

Take snapshot                                        Release snapshot
    |    Start backup                        Finish backup   |
    |        |  Copy data from snapshot images    |          |
------------------------------------------------------------------------->
                                                                         t

In case of failure, for example, when the snapshot is overflowing:

                                           The snapshot is corrupted
Take snapshot                                   | Release snapshot
    |    Start backup                           |   | Finish failed backup
    |        |  Copy data from snapshot images  |   |    |
------------------------------------------------------------------------->
                                                                         t