linux-kernel - Re: [PATCH v2 01/38] backlight/bd6107: Compare against struct fb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 13 Jun 2023 12:47:48 +0200
From:   Thomas Zimmermann <tzimmermann@...e.de>
To:     Daniel Thompson <daniel.thompson@...aro.org>
Cc:     daniel@...ll.ch, javierm@...hat.com, sam@...nborg.org,
        deller@....de, geert+renesas@...der.be, lee@...nel.org,
        jingoohan1@...il.com, dan.carpenter@...aro.org,
        michael.j.ruhl@...el.com, linux-fbdev@...r.kernel.org,
        dri-devel@...ts.freedesktop.org, linux-sh@...r.kernel.org,
        linux-omap@...r.kernel.org, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org,
        Laurent Pinchart <laurent.pinchart+renesas@...asonboard.com>,
        stable@...r.kernel.org
Subject: Re: [PATCH v2 01/38] backlight/bd6107: Compare against struct
 fb_info.device

Hi

Am 13.06.23 um 12:37 schrieb Daniel Thompson:
> On Mon, Jun 12, 2023 at 04:07:39PM +0200, Thomas Zimmermann wrote:
>> Struct bd6107_platform_data refers to a platform device within
>> the Linux device hierarchy. The test in bd6107_backlight_check_fb()
>> compares it against the fbdev device in struct fb_info.dev, which
>> is different. Fix the test by comparing to struct fb_info.device.
>>
>> Fixes a bug in the backlight driver and prepares fbdev for making
>> struct fb_info.dev optional.
>>
>> v2:
>> 	* move renames into separate patch (Javier, Sam, Michael)
>>
>> Fixes: 67b43e590415 ("backlight: Add ROHM BD6107 backlight driver")
>> Signed-off-by: Thomas Zimmermann <tzimmermann@...e.de>
>> Cc: Laurent Pinchart <laurent.pinchart+renesas@...asonboard.com>
>> Cc: Lee Jones <lee@...nel.org>
>> Cc: Daniel Thompson <daniel.thompson@...aro.org>
>> Cc: Jingoo Han <jingoohan1@...il.com>
>> Cc: dri-devel@...ts.freedesktop.org
>> Cc: <stable@...r.kernel.org> # v3.12+
>> Reviewed-by: Javier Martinez Canillas <javierm@...hat.com>
> 
> Reviewed-by: Daniel Thompson <daniel.thompson@...aro.org>

Thanks for going through the backlight patches.

> 
> 
> Daniel.
> 
> PS Please don't treat this as an Acked-by, if you want to land this
>     patchset via a single tree please coordinate with Lee Jones!

I'd like to merge them via drm-misc-next together with the rest of the 
patchset. It's not DRM, but fbdev patches often go through that tree 
quite often.

Best regards
Thomas

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)

Download attachment "OpenPGP_signature" of type "application/pgp-signature" (841 bytes)