linux-kernel - Re: [PATCH v3 08/12] thermal/drivers/ti-soc: remove redundant msg in ti_thermal_expose

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4ee9c4dc-7dfc-3cb8-089d-c1535ab2531c@ti.com>
Date:   Tue, 13 Jun 2023 18:25:34 +0530
From:   "J, KEERTHY" <j-keerthy@...com>
To:     Yangtao Li <frank.li@...o.com>, <glaroque@...libre.com>,
        <rafael@...nel.org>, <daniel.lezcano@...aro.org>,
        <amitk@...nel.org>, <rui.zhang@...el.com>, <shawnguo@...nel.org>,
        <s.hauer@...gutronix.de>, <kernel@...gutronix.de>,
        <festevam@...il.com>, <linux-imx@....com>,
        <thara.gopinath@...il.com>, <agross@...nel.org>,
        <andersson@...nel.org>, <konrad.dybcio@...aro.org>,
        <anarsoul@...il.com>, <tiny.windzz@...il.com>, <wens@...e.org>,
        <jernej.skrabec@...il.com>, <samuel@...lland.org>,
        <thierry.reding@...il.com>, <jonathanh@...dia.com>,
        <edubezval@...il.com>, <matthias.bgg@...il.com>,
        <angelogioacchino.delregno@...labora.com>, <bchihi@...libre.com>,
        <niklas.soderlund+renesas@...natech.se>, <wenst@...omium.org>
CC:     <linux-pm@...r.kernel.org>, <linux-amlogic@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-arm-msm@...r.kernel.org>, <linux-sunxi@...ts.linux.dev>,
        <linux-tegra@...r.kernel.org>, <linux-omap@...r.kernel.org>,
        <linux-mediatek@...ts.infradead.org>
Subject: Re: [PATCH v3 08/12] thermal/drivers/ti-soc: remove redundant msg in
 ti_thermal_expose_sensor()



On 6/13/2023 5:19 PM, Yangtao Li wrote:
> The upper-layer devm_thermal_add_hwmon_sysfs() function can directly
> print error information.

Acked-by: Keerthy <j-keerthy@...com>

> 
> Signed-off-by: Yangtao Li <frank.li@...o.com>
> ---
>   drivers/thermal/ti-soc-thermal/ti-thermal-common.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/thermal/ti-soc-thermal/ti-thermal-common.c b/drivers/thermal/ti-soc-thermal/ti-thermal-common.c
> index 6a5335931f4d..d414a4b7a94a 100644
> --- a/drivers/thermal/ti-soc-thermal/ti-thermal-common.c
> +++ b/drivers/thermal/ti-soc-thermal/ti-thermal-common.c
> @@ -182,8 +182,7 @@ int ti_thermal_expose_sensor(struct ti_bandgap *bgp, int id,
>   	ti_bandgap_write_update_interval(bgp, data->sensor_id,
>   					 TI_BANDGAP_UPDATE_INTERVAL_MS);
>   
> -	if (devm_thermal_add_hwmon_sysfs(bgp->dev, data->ti_thermal))
> -		dev_warn(bgp->dev, "failed to add hwmon sysfs attributes\n");
> +	devm_thermal_add_hwmon_sysfs(bgp->dev, data->ti_thermal); >
>   	return 0;
>   }