linux-kernel - Re: [PATCH v3 02/12] thermal/drivers/sun8i: remove redundant msg in sun8i_ths

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 18 Jun 2023 07:55:59 +0200
From:   Jernej Škrabec <jernej.skrabec@...il.com>
To:     glaroque@...libre.com, rafael@...nel.org,
        daniel.lezcano@...aro.org, amitk@...nel.org, rui.zhang@...el.com,
        shawnguo@...nel.org, s.hauer@...gutronix.de, kernel@...gutronix.de,
        festevam@...il.com, linux-imx@....com, thara.gopinath@...il.com,
        agross@...nel.org, andersson@...nel.org, konrad.dybcio@...aro.org,
        anarsoul@...il.com, tiny.windzz@...il.com, wens@...e.org,
        samuel@...lland.org, thierry.reding@...il.com,
        jonathanh@...dia.com, edubezval@...il.com, j-keerthy@...com,
        matthias.bgg@...il.com, angelogioacchino.delregno@...labora.com,
        bchihi@...libre.com, niklas.soderlund+renesas@...natech.se,
        wenst@...omium.org, Yangtao Li <frank.li@...o.com>
Cc:     linux-pm@...r.kernel.org, linux-amlogic@...ts.infradead.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-arm-msm@...r.kernel.org, linux-sunxi@...ts.linux.dev,
        linux-tegra@...r.kernel.org, linux-omap@...r.kernel.org,
        linux-mediatek@...ts.infradead.org, Yangtao Li <frank.li@...o.com>
Subject: Re: [PATCH v3 02/12] thermal/drivers/sun8i: remove redundant msg in
 sun8i_ths_register()

Dne torek, 13. junij 2023 ob 13:48:54 CEST je Yangtao Li napisal(a):
> The upper-layer devm_thermal_add_hwmon_sysfs() function can directly
> print error information.
> 
> Signed-off-by: Yangtao Li <frank.li@...o.com>

Acked-by: Jernej Skrabec <jernej.skrabec@...il.com>

Best regards,
Jernej

> ---
>  drivers/thermal/sun8i_thermal.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/thermal/sun8i_thermal.c b/drivers/thermal/sun8i_thermal.c
> index 793ddce72132..066f9fed9b86 100644
> --- a/drivers/thermal/sun8i_thermal.c
> +++ b/drivers/thermal/sun8i_thermal.c
> @@ -475,9 +475,7 @@ static int sun8i_ths_register(struct ths_device *tmdev)
>  		if (IS_ERR(tmdev->sensor[i].tzd))
>  			return PTR_ERR(tmdev->sensor[i].tzd);
>  
> -		if (devm_thermal_add_hwmon_sysfs(tmdev->dev, tmdev->sensor[i].tzd))
> -			dev_warn(tmdev->dev,
> -				 "Failed to add hwmon sysfs attributes\n");
> +		devm_thermal_add_hwmon_sysfs(tmdev->dev, tmdev->sensor[i].tzd);
>  	}
>  
>  	return 0;
>