linux-kernel - Re: [PATCH] zram: further limit recompression threshold

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADyq12xoEKpYOd7nFy+ET89ss-zTdKbbj6870UMDQeLe09=Zow@mail.gmail.com>
Date:   Wed, 14 Jun 2023 10:16:03 -0400
From:   Brian Geffon <bgeffon@...gle.com>
To:     Sergey Senozhatsky <senozhatsky@...omium.org>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Minchan Kim <minchan@...nel.org>, Jens Axboe <axboe@...nel.dk>,
        linux-kernel@...r.kernel.org, linux-block@...r.kernel.org
Subject: Re: [PATCH] zram: further limit recompression threshold

Thanks Sergey

On Wed, Jun 14, 2023 at 10:13 AM Sergey Senozhatsky
<senozhatsky@...omium.org> wrote:
>
> Recompression threshold should be below huge-size-class
> watermark.

Acked-by: Brian Geffon <bgeffon@...gle.com>

>
> Suggested-by: Brian Geffon <bgeffon@...gle.com>
> Signed-off-by: Sergey Senozhatsky <senozhatsky@...omium.org>
> ---
>  drivers/block/zram/zram_drv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c
> index 1867f378b319..5676e6dd5b16 100644
> --- a/drivers/block/zram/zram_drv.c
> +++ b/drivers/block/zram/zram_drv.c
> @@ -1753,7 +1753,7 @@ static ssize_t recompress_store(struct device *dev,
>                 }
>         }
>
> -       if (threshold >= PAGE_SIZE)
> +       if (threshold >= huge_class_size)
>                 return -EINVAL;
>
>         down_read(&zram->init_lock);
> --
> 2.41.0.162.gfafddb0af9-goog
>