linux-kernel - Re: [PATCH] zram: further limit recompression threshold

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20230614125210.3c6b5c1e34e18fbca7f59dae@linux-foundation.org>
Date:   Wed, 14 Jun 2023 12:52:10 -0700
From:   Andrew Morton <akpm@...ux-foundation.org>
To:     Sergey Senozhatsky <senozhatsky@...omium.org>
Cc:     Minchan Kim <minchan@...nel.org>, Jens Axboe <axboe@...nel.dk>,
        linux-kernel@...r.kernel.org, linux-block@...r.kernel.org,
        Brian Geffon <bgeffon@...gle.com>
Subject: Re: [PATCH] zram: further limit recompression threshold

On Wed, 14 Jun 2023 23:13:12 +0900 Sergey Senozhatsky <senozhatsky@...omium.org> wrote:

> Recompression threshold should be below huge-size-class
> watermark.

The changelog explains what the code does, but not why it does it?

> --- a/drivers/block/zram/zram_drv.c
> +++ b/drivers/block/zram/zram_drv.c
> @@ -1753,7 +1753,7 @@ static ssize_t recompress_store(struct device *dev,
>  		}
>  	}
>  
> -	if (threshold >= PAGE_SIZE)
> +	if (threshold >= huge_class_size)
>  		return -EINVAL;
>  
>  	down_read(&zram->init_lock);
> -- 
> 2.41.0.162.gfafddb0af9-goog