linux-kernel - Re: [PATCH 2/2] dt-bindings: crypto: fsl,sec-v4.0-mon: Add "linux,keycodes" and deprecate "linux,keycode"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL_JsqJFT630XJ8xOrz47w5bMbGv12koCHc1NdhQQANdTrE4ow@mail.gmail.com>
Date:   Wed, 14 Jun 2023 08:53:20 -0600
From:   Rob Herring <robh@...nel.org>
To:     Conor Dooley <conor@...nel.org>
Cc:     Horia Geantă <horia.geanta@....com>,
        Pankaj Gupta <pankaj.gupta@....com>,
        Gaurav Jain <gaurav.jain@....com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        "David S. Miller" <davem@...emloft.net>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        linux-crypto@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] dt-bindings: crypto: fsl,sec-v4.0-mon: Add
 "linux,keycodes" and deprecate "linux,keycode"

On Tue, Jun 13, 2023 at 3:11 PM Conor Dooley <conor@...nel.org> wrote:
>
> On Tue, Jun 13, 2023 at 02:12:30PM -0600, Rob Herring wrote:
> > The "linux,keycode" property is non-standard. Add the common property
> > "linux,keycodes" and mark "linux,keycode" deprecated so that the mistake
> > is not propagated.
>
> This is actually used in the driver for this device, should the driver
> not also be updated to use the corrected property?

Yes, but that doesn't have to be in sync with the binding change. I
mainly want to add this so it doesn't get propagated to new users
rather than move this case off of linux,keycode. Also, the input
subsystem should probably have a common function to read
linux,keycodes as right now every driver does it.

Rob