[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230614-glutton-crispy-0d9588a97a1c@spud>
Date: Wed, 14 Jun 2023 18:26:56 +0100
From: Conor Dooley <conor@...nel.org>
To: Rob Herring <robh@...nel.org>
Cc: Horia Geantă <horia.geanta@....com>,
Pankaj Gupta <pankaj.gupta@....com>,
Gaurav Jain <gaurav.jain@....com>,
Herbert Xu <herbert@...dor.apana.org.au>,
"David S. Miller" <davem@...emloft.net>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>,
linux-crypto@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] dt-bindings: crypto: fsl,sec-v4.0-mon: Add
"linux,keycodes" and deprecate "linux,keycode"
On Wed, Jun 14, 2023 at 08:53:20AM -0600, Rob Herring wrote:
> On Tue, Jun 13, 2023 at 3:11 PM Conor Dooley <conor@...nel.org> wrote:
> >
> > On Tue, Jun 13, 2023 at 02:12:30PM -0600, Rob Herring wrote:
> > > The "linux,keycode" property is non-standard. Add the common property
> > > "linux,keycodes" and mark "linux,keycode" deprecated so that the mistake
> > > is not propagated.
> >
> > This is actually used in the driver for this device, should the driver
> > not also be updated to use the corrected property?
>
> Yes, but that doesn't have to be in sync with the binding change. I
> mainly want to add this so it doesn't get propagated to new users
> rather than move this case off of linux,keycode. Also, the input
> subsystem should probably have a common function to read
> linux,keycodes as right now every driver does it.
Perhaps one of the nxp folk in the audience should have a crack at that
so.
Acked-by: Conor Dooley <conor.dooley@...rochip.com>
Cheers,
Conor.
Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)
Powered by blists - more mailing lists