linux-kernel - Re: [PATCH][next] ARM: OMAP2+: Fix -Warray-bounds warning in _pwrdm_state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230614080740.GH14287@atomide.com>
Date:   Wed, 14 Jun 2023 11:07:40 +0300
From:   Tony Lindgren <tony@...mide.com>
To:     "Gustavo A. R. Silva" <gustavoars@...nel.org>
Cc:     Russell King <linux@...linux.org.uk>,
        Peter 'p2' De Schrijver <peter.de-schrijver@...ia.com>,
        Kevin Hilman <khilman@...prootsystems.com>,
        linux-omap@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, linux-hardening@...r.kernel.org
Subject: Re: [PATCH][next] ARM: OMAP2+: Fix -Warray-bounds warning in
 _pwrdm_state_switch()

* Gustavo A. R. Silva <gustavoars@...nel.org> [230608 07:11]:
> If function pwrdm_read_prev_pwrst() returns -EINVAL, we will end
> up accessing array pwrdm->state_counter through negative index
> -22. This is wrong and the compiler is legitimately warning us
> about this potential problem.
> 
> Fix this by sanity checking the value stored in variable _prev_
> before accessing array pwrdm->state_counter.
> 
> Address the following -Warray-bounds warning:
> arch/arm/mach-omap2/powerdomain.c:178:45: warning: array subscript -22 is below array bounds of 'unsigned int[4]' [-Warray-bounds]

Thanks applying into omap-for-v6.5/cleanup, seems this can wait
for the merge window.

Regards,

Tony