linux-kernel - RE: [PATCH v7 3/4] iommu/vt-d: Add set_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BN9PR11MB5276BB62057559D4EE4C8A588C5AA@BN9PR11MB5276.namprd11.prod.outlook.com>
Date:   Wed, 14 Jun 2023 08:10:42 +0000
From:   "Tian, Kevin" <kevin.tian@...el.com>
To:     Baolu Lu <baolu.lu@...ux.intel.com>,
        Jacob Pan <jacob.jun.pan@...ux.intel.com>,
        LKML <linux-kernel@...r.kernel.org>,
        "iommu@...ts.linux.dev" <iommu@...ts.linux.dev>,
        Jason Gunthorpe <jgg@...dia.com>,
        Joerg Roedel <joro@...tes.org>,
        Robin Murphy <robin.murphy@....com>,
        Jean-Philippe Brucker <jean-philippe@...aro.com>,
        "dmaengine@...r.kernel.org" <dmaengine@...r.kernel.org>,
        "vkoul@...nel.org" <vkoul@...nel.org>
CC:     Will Deacon <will@...nel.org>,
        David Woodhouse <dwmw2@...radead.org>,
        "Raj, Ashok" <ashok.raj@...el.com>,
        "Liu, Yi L" <yi.l.liu@...el.com>,
        "Yu, Fenghua" <fenghua.yu@...el.com>,
        "Jiang, Dave" <dave.jiang@...el.com>,
        "Luck, Tony" <tony.luck@...el.com>,
        "Zanussi, Tom" <tom.zanussi@...el.com>,
        "Ranganathan, Narayan" <narayan.ranganathan@...el.com>
Subject: RE: [PATCH v7 3/4] iommu/vt-d: Add set_dev_pasid callback for dma
 domain

> From: Baolu Lu <baolu.lu@...ux.intel.com>
> Sent: Friday, May 26, 2023 10:43 AM
> 
> >
> >> +
> >> +	ret = domain_attach_iommu(dmar_domain, iommu);
> >> +	if (ret)
> >> +		goto out_free;
> >> +
> >> +	if (domain_type_is_si(dmar_domain))
> >> +		ret = intel_pasid_setup_pass_through(iommu, dmar_domain,
> >> +						     dev, pasid);
> >> +	else if (dmar_domain->use_first_level)
> >> +		ret = domain_setup_first_level(iommu, dmar_domain,
> >> +					       dev, pasid);
> >> +	else
> >> +		ret = intel_pasid_setup_second_level(iommu, dmar_domain,
> >> +						     dev, pasid);
> >
> > Here you allow attaching pasid to a domain using second-level but all
> > prior changes are only for first-level.
> 
> As explained, prior changes are for pasid-base iotlb invalidation for
> first level page table change. Or perhaps I didn't get you correctly?
> 

No. you are correct.