linux-kernel - Re: [PATCH v1] drivers/i2c/muxes:Fix resource leaks in device_for_each_child

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bc8a4601-2651-cd69-42d2-f34992f797eb@kernel.org>
Date:   Wed, 14 Jun 2023 14:02:13 +0200
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Andi Shyti <andi.shyti@...nel.org>, Wang Ming <machel@...o.com>
Cc:     Peter Korsgaard <peter.korsgaard@...co.com>,
        Peter Rosin <peda@...ntia.se>, linux-i2c@...r.kernel.org,
        linux-kernel@...r.kernel.org, opensource.kernel@...o.com
Subject: Re: [PATCH v1] drivers/i2c/muxes:Fix resource leaks in
 device_for_each_child_node() loops

On 14/06/2023 13:43, Andi Shyti wrote:
> Hi Wang,
> 
>> diff --git a/drivers/i2c/muxes/i2c-mux-gpio.c b/drivers/i2c/muxes/i2c-mux-gpio.c
>> index 5d5cbe013..90966de7a 100644
>> --- a/drivers/i2c/muxes/i2c-mux-gpio.c
>> +++ b/drivers/i2c/muxes/i2c-mux-gpio.c
>> @@ -106,6 +106,7 @@ static int i2c_mux_gpio_probe_fw(struct gpiomux *mux,
>>                 } else if (is_acpi_node(child)) {
>>                         rc = acpi_get_local_address(ACPI_HANDLE_FWNODE(child), values + i);
>>                         if (rc)
>> +                               fwnode_handle_put(child);
>>                                 return dev_err_probe(dev, rc, "Cannot get address\n");
>>                 }
> 
> please, read it again and tell me what's wrong :)


No, we can't tell what's wrong because:

> The contents of this message and any attachments may contain
> confidential and/or privileged information

:)

Wang,
Just run the sparse and smatch before posting patches.

Best regards,
Krzysztof