linux-kernel - Re: [PATCH] Revert "ext4: remove unnecessary check in ext4_bg_num_gdb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <168683994078.282246.12341856291517677835.b4-ty@mit.edu>
Date:   Thu, 15 Jun 2023 10:59:56 -0400
From:   "Theodore Ts'o" <tytso@....edu>
To:     adilger.kernel@...ger.ca, Kemeng Shi <shikemeng@...weicloud.com>
Cc:     "Theodore Ts'o" <tytso@....edu>, s.l-h@....de,
        linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Revert "ext4: remove unnecessary check in ext4_bg_num_gdb_nometa"


On Wed, 14 Jun 2023 06:50:25 +0800, Kemeng Shi wrote:
> This reverts commit ad3f09be6cfe332be8ff46c78e6ec0f8839107aa.
> 
> The reverted commit was intended to simpfy the code to get group
> descriptor block number in non-meta block group by assuming
> s_gdb_count is block number used for all non-meta block group descriptors.
> However s_gdb_count is block number used for all meta *and* non-meta
> group descriptors. So s_gdb_group will be > actual group descriptor block
> number used for all non-meta block group which should be "total non-meta
> block group" / "group descriptors per block", e.g. s_first_meta_bg.
> 
> [...]

Applied, thanks!

[1/1] Revert "ext4: remove unnecessary check in ext4_bg_num_gdb_nometa"
      commit: 19482792113fa1dc419f9bc7b04b9dbdaa5256fd

Best regards,
-- 
Theodore Ts'o <tytso@....edu>