linux-kernel - Re: [PATCH] ext4: Drop the call to ext4_error() from ext4_get_group

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <168683994079.282246.8360074850989025705.b4-ty@mit.edu>
Date:   Thu, 15 Jun 2023 10:59:54 -0400
From:   "Theodore Ts'o" <tytso@....edu>
To:     Andreas Dilger <adilger.kernel@...ger.ca>,
        linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org,
        "Fabio M. De Francesco" <fmdefrancesco@...il.com>
Cc:     "Theodore Ts'o" <tytso@....edu>,
        syzbot+4acc7d910e617b360859@...kaller.appspotmail.com
Subject: Re: [PATCH] ext4: Drop the call to ext4_error() from ext4_get_group_info()


On Wed, 14 Jun 2023 12:02:55 +0200, Fabio M. De Francesco wrote:
> A recent patch added a call to ext4_error() which is problematic since
> some callers of the ext4_get_group_info() function may be holding a
> spinlock, whereas ext4_error() must never be called in atomic context.
> 
> This triggered a report from Syzbot: "BUG: sleeping function called from
> invalid context in ext4_update_super" (see the link below).
> 
> [...]

Applied, thanks!

[1/1] ext4: Drop the call to ext4_error() from ext4_get_group_info()
      commit: f451fd97dd2b78f286379203a47d9d295c467255

Best regards,
-- 
Theodore Ts'o <tytso@....edu>