linux-kernel - Re: [PATCH v1 10/21] powerpc/kexec: refactor for kernel/Kconfig.kexec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230615161952.GD19790@gate.crashing.org>
Date:   Thu, 15 Jun 2023 11:19:52 -0500
From:   Segher Boessenkool <segher@...nel.crashing.org>
To:     Michael Ellerman <mpe@...erman.id.au>
Cc:     Eric DeVolder <eric.devolder@...cle.com>, linux@...linux.org.uk,
        catalin.marinas@....com, will@...nel.org, chenhuacai@...nel.org,
        geert@...ux-m68k.org, tsbogend@...ha.franken.de,
        James.Bottomley@...senPartnership.com, deller@....de,
        ysato@...rs.osdn.me, dalias@...c.org, glaubitz@...sik.fu-berlin.de,
        tglx@...utronix.de, mingo@...hat.com, bp@...en8.de,
        dave.hansen@...ux.intel.com, 86@...nel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-ia64@...r.kernel.org, loongarch@...ts.linux.dev,
        linux-m68k@...r.kernel.org, linux-mips@...r.kernel.org,
        linux-parisc@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
        linux-riscv@...ts.infradead.org, linux-s390@...r.kernel.org,
        linux-sh@...r.kernel.org, peterz@...radead.org,
        linus.walleij@...aro.org, thunder.leizhen@...wei.com,
        hpa@...or.com, kernel@...0n.name, ardb@...nel.org, tsi@...oix.net,
        agordeev@...ux.ibm.com, paulmck@...nel.org, bhe@...hat.com,
        masahiroy@...nel.org, konrad.wilk@...cle.com,
        sebastian.reichel@...labora.com, samitolvanen@...gle.com,
        ojeda@...nel.org, juerg.haefliger@...onical.com,
        borntraeger@...ux.ibm.com, frederic@...nel.org, arnd@...db.de,
        mhiramat@...nel.org, aou@...s.berkeley.edu, keescook@...omium.org,
        gor@...ux.ibm.com, anshuman.khandual@....com, hca@...ux.ibm.com,
        xin3.li@...el.com, npiggin@...il.com, rmk+kernel@...linux.org.uk,
        paul.walmsley@...ive.com, boris.ostrovsky@...cle.com,
        ziy@...dia.com, hbathini@...ux.ibm.com, gregkh@...uxfoundation.org,
        kirill.shutemov@...ux.intel.com, ndesaulniers@...gle.com,
        sourabhjain@...ux.ibm.com, palmer@...belt.com, svens@...ux.ibm.com,
        tj@...nel.org, akpm@...ux-foundation.org, rppt@...nel.org
Subject: Re: [PATCH v1 10/21] powerpc/kexec: refactor for kernel/Kconfig.kexec

On Thu, Jun 15, 2023 at 01:34:25PM +1000, Michael Ellerman wrote:
> Eric DeVolder <eric.devolder@...cle.com> writes:
> > -config KEXEC_FILE
> > -	bool "kexec file based system call"
> > -	select KEXEC_CORE
> > -	select HAVE_IMA_KEXEC if IMA
> > -	select KEXEC_ELF
> > -	depends on PPC64
> > -	depends on CRYPTO=y
> > -	depends on CRYPTO_SHA256=y
> ...
> > +
> > +config ARCH_HAS_KEXEC_FILE
> > +	def_bool PPC64 && CRYPTO && CRYPTO_SHA256
> 
> The =y's got lost here.
> 
> I think they were both meaningful, because both options are tristate. So
> this previously required them to be built-in (=y), whereas after your
> patch it will allow them to be modules.
> 
> I don't know for sure that those options need to be built-in, but that's
> what the code does now, so this patch shouldn't change it, at least
> without an explanation.

This patch shouldn't change it at all, period.  If you want to change it
(and that sounds like a good idea, if it is possible anyway), that
should be a separate patch.


Segher