linux-kernel - Re: [PATCH] mm: pass nid to reserve_bootmem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 16 Jun 2023 01:42:24 +0800
From:   kernel test robot <lkp@...el.com>
To:     Yajun Deng <yajun.deng@...ux.dev>, akpm@...ux-foundation.org,
        rppt@...nel.org
Cc:     llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
        linux-mm@...ck.org, linux-kernel@...r.kernel.org,
        Yajun Deng <yajun.deng@...ux.dev>
Subject: Re: [PATCH] mm: pass nid to reserve_bootmem_region()

Hi Yajun,

kernel test robot noticed the following build errors:

[auto build test ERROR on akpm-mm/mm-everything]

url:    https://github.com/intel-lab-lkp/linux/commits/Yajun-Deng/mm-pass-nid-to-reserve_bootmem_region/20230615-190631
base:   https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
patch link:    https://lore.kernel.org/r/20230615110355.1694461-1-yajun.deng%40linux.dev
patch subject: [PATCH] mm: pass nid to reserve_bootmem_region()
config: arm-randconfig-r023-20230614 (https://download.01.org/0day-ci/archive/20230616/202306160145.juJMr3Bi-lkp@intel.com/config)
compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07)
reproduce (this is a W=1 build):
        mkdir -p ~/bin
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm cross compiling tool for clang build
        # apt-get install binutils-arm-linux-gnueabi
        git remote add akpm-mm https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git
        git fetch akpm-mm mm-everything
        git checkout akpm-mm/mm-everything
        b4 shazam https://lore.kernel.org/r/20230615110355.1694461-1-yajun.deng@linux.dev
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang ~/bin/make.cross W=1 O=build_dir ARCH=arm olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang ~/bin/make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202306160145.juJMr3Bi-lkp@intel.com/

All errors (new ones prefixed by >>):

>> mm/memblock.c:2098:18: error: no member named 'nid' in 'struct memblock_region'
                           nid = region->nid;
                                 ~~~~~~  ^
   1 error generated.


vim +2098 mm/memblock.c

  2080	
  2081	static void __init memmap_init_reserved_pages(void)
  2082	{
  2083		struct memblock_region *region;
  2084		phys_addr_t start, end;
  2085		int nid;
  2086		u64 i;
  2087	
  2088		/* initialize struct pages for the reserved regions */
  2089		__for_each_mem_range(i, &memblock.reserved, NULL, NUMA_NO_NODE,
  2090				     MEMBLOCK_NONE, &start, &end, &nid)
  2091			reserve_bootmem_region(start, end, nid);
  2092	
  2093		/* and also treat struct pages for the NOMAP regions as PageReserved */
  2094		for_each_mem_region(region) {
  2095			if (memblock_is_nomap(region)) {
  2096				start = region->base;
  2097				end = start + region->size;
> 2098				nid = region->nid;
  2099				reserve_bootmem_region(start, end, nid);
  2100			}
  2101		}
  2102	}
  2103	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki